From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, Li Jian <lazycat-xiao@foxmail.com>,
lgirdwood@gmail.com, loongarch@vger.kernel.org,
zhoubinbin@loongson.cn, jeffbai@aosc.io, stable@vger.kernel.org,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Zhang Yi <zhangyi@everest-semi.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Alexandru Ardelean <aardelean@deviqon.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-sound@vger.kernel.org, Huacai Chen <chenhuacai@kernel.org>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH] ASoC: ES8389: convert to devm_clk_get_optional() to get clock
Date: Mon, 27 Apr 2026 19:00:59 +0200 [thread overview]
Message-ID: <ae-VofUzVa_ladMh@monoceros> (raw)
In-Reply-To: <177724622731.266775.3161558352144649934.b4-ty@b4>
[-- Attachment #1: Type: text/plain, Size: 888 bytes --]
On Mon, Apr 27, 2026 at 08:30:27AM +0900, Mark Brown wrote:
> On Fri, 17 Apr 2026 18:53:14 +0800, Li Jian wrote:
> > ASoC: ES8389: convert to devm_clk_get_optional() to get clock
>
> Applied to
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.1
>
> Thanks!
>
> [1/1] ASoC: ES8389: convert to devm_clk_get_optional() to get clock
> https://git.kernel.org/broonie/sound/c/8ed331113107
I see you dropped the Fixes: line, but I still think the commit log is
wrongly blaming abae8e57e49a. Unless I'm missing something, abae8e57e49a
didn't change behaviour of devm_clk_get() or devm_clk_get_optional(), so
"since commit abae8e57e49a ("clk: generalize devm_clk_get() a bit"),
devm_clk_get() would return an error pointer when a clock source was not
detected (instead of falling back to a static clock)," is wrong.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-04-27 17:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 10:53 [PATCH] ASoC: ES8389: convert to devm_clk_get_optional() to get clock Li Jian
2026-04-17 13:34 ` Uwe Kleine-König
2026-04-18 8:18 ` Li Jian
2026-04-18 11:40 ` Uwe Kleine-König
2026-04-26 23:30 ` Mark Brown
2026-04-27 17:00 ` Uwe Kleine-König [this message]
2026-04-28 0:03 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2026-04-17 10:16 Li Jian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae-VofUzVa_ladMh@monoceros \
--to=u.kleine-koenig@pengutronix.de \
--cc=aardelean@deviqon.com \
--cc=broonie@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=jeffbai@aosc.io \
--cc=jic23@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lazycat-xiao@foxmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=loongarch@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=zhangyi@everest-semi.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox