From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Li Jian <lazycat-xiao@foxmail.com>
Cc: linux-kernel@vger.kernel.org, lgirdwood@gmail.com,
loongarch@vger.kernel.org, chenhuacai@loongson.cn,
zhoubinbin@loongson.cn, jeffbai@aosc.io, stable@vger.kernel.org,
Mark Brown <broonie@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Zhang Yi <zhangyi@everest-semi.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Alexandru Ardelean <aardelean@deviqon.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-sound@vger.kernel.org
Subject: Re: [PATCH] ASoC: ES8389: convert to devm_clk_get_optional() to get clock
Date: Fri, 17 Apr 2026 15:34:04 +0200 [thread overview]
Message-ID: <aeI1_C5WGY5SzzcD@monoceros> (raw)
In-Reply-To: <tencent_7C78374FB9F4B3A37101E5C719715D8BC40A@qq.com>
[-- Attachment #1: Type: text/plain, Size: 926 bytes --]
Hello,
On Fri, Apr 17, 2026 at 06:53:14PM +0800, Li Jian wrote:
> When enabling ES8390 via ACPI description, es8389 would fail to
> obtain a clock source, causing the driver to fail to initialize.
> This was not an issue with older kernels, but since commit
> abae8e57e49a ("clk: generalize devm_clk_get() a bit"),
> devm_clk_get() would return an error pointer when a clock source
> was not detected (instead of falling back to a static clock),
> causing the driver to fail early.
>
> Use devm_clk_get_optional() instead to return to the previous
> behaviour, allowing the use of a static clock source.
>
> Cc: stable@vger.kernel.org
> Fixes: abae8e57e49a ("clk: generalize devm_clk_get() a bit")
Are you sure you identified the breaking commit correctly? I intended
the patch not to introduce any semantic change, and even with your claim
I don't spot the issue in abae8e57e49a.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-04-17 13:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 10:53 [PATCH] ASoC: ES8389: convert to devm_clk_get_optional() to get clock Li Jian
2026-04-17 13:34 ` Uwe Kleine-König [this message]
2026-04-18 8:18 ` Li Jian
2026-04-18 11:40 ` Uwe Kleine-König
-- strict thread matches above, loose matches on Subject: below --
2026-04-17 10:16 Li Jian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeI1_C5WGY5SzzcD@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=aardelean@deviqon.com \
--cc=broonie@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=ckeepax@opensource.cirrus.com \
--cc=jeffbai@aosc.io \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lazycat-xiao@foxmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=loongarch@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=zhangyi@everest-semi.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox