stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Please backport d289d5307762 ("ip6_vti: set netns_immutable on the fallback device.") to 6.6.y and older
@ 2026-06-18  5:33 Salvatore Bonaccorso
  2026-06-20 11:54 ` Sasha Levin
  0 siblings, 1 reply; 3+ messages in thread
From: Salvatore Bonaccorso @ 2026-06-18  5:33 UTC (permalink / raw)
  To: stable, Greg Kroah-Hartman, Sasha Levin
  Cc: Eric Dumazet, Noam Rathaus, Steffen Klassert, Nicolas Dichtel,
	Jakub Kicinski, Ben Hutchings

Hi

d289d5307762 ("ip6_vti: set netns_immutable on the fallback device.")
was already queued for 7.0.13-rc1 and 6.18.36-rc1:
https://lore.kernel.org/all/20260616145117.258480602@linuxfoundation.org/
https://lore.kernel.org/all/20260616145103.487984074@linuxfoundation.org/
but not for the older series as needed.

A backport for 6.12.y was added in
https://lore.kernel.org/stable/ajJ6TSzxuWdfQkxf@eldamar.lan/ .

Here is the backport for 6.6.y and older for versions which do not
have netns_local.

Does that look ok?

Regards,
Salvatore

From baba4cc5ae46577aa7fc4f163c0dc44833298d9d Mon Sep 17 00:00:00 2001
From: Eric Dumazet <edumazet@google.com>
Date: Mon, 8 Jun 2026 15:59:18 +0000
Subject: [PATCH] ip6_vti: set netns_immutable on the fallback device.

[ Upstream commit d289d5307762d1838aaece22c6b6fcad9e8865f9 ]

john1988 and Noam Rathaus reported that vti6_init_net() does not set the
netns_immutable flag on the per-netns fallback tunnel device (ip6_vti0).

Other similar tunnel drivers (like ip6_tunnel, sit, ip6_gre, and ip_tunnel)
correctly set this flag during their fallback device initialization to
prevent them from being moved to another network namespace.

Fixes: 61220ab34948 ("vti6: Enable namespace changing")
Reported-by: Noam Rathaus <noamr@ssd-disclosure.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Steffen Klassert <steffen.klassert@secunet.com>
Reviewed-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Link: https://patch.msgid.link/20260608155918.787644-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
[Salvatore Bonaccorso: Backport for version without 0c493da86374 ("net:
rename netns_local to netns_immutable") in v6.15-rc1 and without
05c1280a2bcf ("netdev_features: convert NETIF_F_NETNS_LOCAL to
dev->netns_local") in v6.12-rc1 and use NETIF_F_NETNS_LOCAL device
feature.]
Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
---
 net/ipv6/ip6_vti.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/ipv6/ip6_vti.c b/net/ipv6/ip6_vti.c
index 04e4368fe465..33b21ecd51ba 100644
--- a/net/ipv6/ip6_vti.c
+++ b/net/ipv6/ip6_vti.c
@@ -1155,6 +1155,7 @@ static int __net_init vti6_init_net(struct net *net)
 		goto err_alloc_dev;
 	dev_net_set(ip6n->fb_tnl_dev, net);
 	ip6n->fb_tnl_dev->rtnl_link_ops = &vti6_link_ops;
+	ip6n->fb_tnl_dev->features |= NETIF_F_NETNS_LOCAL;
 
 	err = vti6_fb_tnl_dev_init(ip6n->fb_tnl_dev);
 	if (err < 0)
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: Please backport d289d5307762 ("ip6_vti: set netns_immutable on the fallback device.") to 6.6.y and older
  2026-06-18  5:33 Please backport d289d5307762 ("ip6_vti: set netns_immutable on the fallback device.") to 6.6.y and older Salvatore Bonaccorso
@ 2026-06-20 11:54 ` Sasha Levin
  2026-06-20 15:38   ` Salvatore Bonaccorso
  0 siblings, 1 reply; 3+ messages in thread
From: Sasha Levin @ 2026-06-20 11:54 UTC (permalink / raw)
  To: stable, Greg Kroah-Hartman
  Cc: Sasha Levin, Eric Dumazet, Noam Rathaus, Steffen Klassert,
	Nicolas Dichtel, Jakub Kicinski, Ben Hutchings,
	Salvatore Bonaccorso

> Please backport d289d5307762 ("ip6_vti: set netns_immutable on the fallback device.") to 6.6.y and older

Queued for 6.6, 6.1, 5.15 and 5.10, thanks.

-- 
Thanks,
Sasha

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Please backport d289d5307762 ("ip6_vti: set netns_immutable on the fallback device.") to 6.6.y and older
  2026-06-20 11:54 ` Sasha Levin
@ 2026-06-20 15:38   ` Salvatore Bonaccorso
  0 siblings, 0 replies; 3+ messages in thread
From: Salvatore Bonaccorso @ 2026-06-20 15:38 UTC (permalink / raw)
  To: Sasha Levin
  Cc: stable, Greg Kroah-Hartman, Eric Dumazet, Noam Rathaus,
	Steffen Klassert, Nicolas Dichtel, Jakub Kicinski, Ben Hutchings

Hi,

On Sat, Jun 20, 2026 at 07:54:52AM -0400, Sasha Levin wrote:
> > Please backport d289d5307762 ("ip6_vti: set netns_immutable on the fallback device.") to 6.6.y and older
> 
> Queued for 6.6, 6.1, 5.15 and 5.10, thanks.

Thanks. Can you please queue up as well the one for 6.12.y?

https://lore.kernel.org/stable/ajJ6TSzxuWdfQkxf@eldamar.lan/

Regards,
Salvatore

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-06-20 15:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-18  5:33 Please backport d289d5307762 ("ip6_vti: set netns_immutable on the fallback device.") to 6.6.y and older Salvatore Bonaccorso
2026-06-20 11:54 ` Sasha Levin
2026-06-20 15:38   ` Salvatore Bonaccorso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).