* [PATCH v2 1/3] media: qcom: camss: Add "gcc_axi_hf" to 8775p VFE lite clock lists
@ 2026-07-23 11:09 Hans de Goede
2026-07-23 11:30 ` Vladimir Zapolskiy
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Hans de Goede @ 2026-07-23 11:09 UTC (permalink / raw)
To: Bryan O'Donoghue, Vladimir Zapolskiy, Loic Poulain
Cc: Hans de Goede, Wenmeng Liu, linux-media, linux-arm-msm, stable
The "gcc_axi_hf" clock is correctly listed in the clock list of the
8775p 2 main VFE-s, but it is missing from all the VFE-lite clock lists,
causing these to not work on platforms where the firmware allows turning
off "gcc_axi_hf".
Add the missing "gcc_axi_hf" to fix the VFE-lite blocks not working on
these platforms.
Fixes: 924f45e58b1fe ("media: qcom: camss: Add missing clocks for VFE lite on sa8775p")
Cc: stable@vger.kernel.org
Suggested-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
---
Changes in v2:
- Also update clock_rate lists
- Add missing Fixes: tag
---
drivers/media/platform/qcom/camss/camss.c | 25 ++++++++++++++---------
1 file changed, 15 insertions(+), 10 deletions(-)
diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
index 2123f6388e3d..68491b16d647 100644
--- a/drivers/media/platform/qcom/camss/camss.c
+++ b/drivers/media/platform/qcom/camss/camss.c
@@ -4037,10 +4037,11 @@ static const struct camss_subdev_resources vfe_res_8775p[] = {
/* VFE2 (lite) */
{
.regulators = {},
- .clock = { "cpas_ahb", "cpas_vfe_lite", "vfe_lite_ahb",
- "vfe_lite_csid", "vfe_lite_cphy_rx",
+ .clock = { "cpas_ahb", "gcc_axi_hf", "cpas_vfe_lite",
+ "vfe_lite_ahb", "vfe_lite_csid", "vfe_lite_cphy_rx",
"vfe_lite", "camnoc_axi"},
.clock_rate = {
+ { 0 },
{ 0 },
{ 0 },
{ 300000000, 400000000, 400000000, 400000000 },
@@ -4062,10 +4063,11 @@ static const struct camss_subdev_resources vfe_res_8775p[] = {
/* VFE3 (lite) */
{
.regulators = {},
- .clock = { "cpas_ahb", "cpas_vfe_lite", "vfe_lite_ahb",
- "vfe_lite_csid", "vfe_lite_cphy_rx",
+ .clock = { "cpas_ahb", "gcc_axi_hf", "cpas_vfe_lite",
+ "vfe_lite_ahb", "vfe_lite_csid", "vfe_lite_cphy_rx",
"vfe_lite", "camnoc_axi"},
.clock_rate = {
+ { 0 },
{ 0 },
{ 0 },
{ 300000000, 400000000, 400000000, 400000000 },
@@ -4087,10 +4089,11 @@ static const struct camss_subdev_resources vfe_res_8775p[] = {
/* VFE4 (lite) */
{
.regulators = {},
- .clock = { "cpas_ahb", "cpas_vfe_lite", "vfe_lite_ahb",
- "vfe_lite_csid", "vfe_lite_cphy_rx",
+ .clock = { "cpas_ahb", "gcc_axi_hf", "cpas_vfe_lite",
+ "vfe_lite_ahb", "vfe_lite_csid", "vfe_lite_cphy_rx",
"vfe_lite", "camnoc_axi"},
.clock_rate = {
+ { 0 },
{ 0 },
{ 0 },
{ 300000000, 400000000, 400000000, 400000000 },
@@ -4112,10 +4115,11 @@ static const struct camss_subdev_resources vfe_res_8775p[] = {
/* VFE5 (lite) */
{
.regulators = {},
- .clock = { "cpas_ahb", "cpas_vfe_lite", "vfe_lite_ahb",
- "vfe_lite_csid", "vfe_lite_cphy_rx",
+ .clock = { "cpas_ahb", "gcc_axi_hf", "cpas_vfe_lite",
+ "vfe_lite_ahb", "vfe_lite_csid", "vfe_lite_cphy_rx",
"vfe_lite", "camnoc_axi"},
.clock_rate = {
+ { 0 },
{ 0 },
{ 0 },
{ 300000000, 400000000, 400000000, 400000000 },
@@ -4137,10 +4141,11 @@ static const struct camss_subdev_resources vfe_res_8775p[] = {
/* VFE6 (lite) */
{
.regulators = {},
- .clock = { "cpas_ahb", "cpas_vfe_lite", "vfe_lite_ahb",
- "vfe_lite_csid", "vfe_lite_cphy_rx",
+ .clock = { "cpas_ahb", "gcc_axi_hf", "cpas_vfe_lite",
+ "vfe_lite_ahb", "vfe_lite_csid", "vfe_lite_cphy_rx",
"vfe_lite", "camnoc_axi"},
.clock_rate = {
+ { 0 },
{ 0 },
{ 0 },
{ 300000000, 400000000, 400000000, 400000000 },
--
2.55.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/3] media: qcom: camss: Add "gcc_axi_hf" to 8775p VFE lite clock lists
2026-07-23 11:09 [PATCH v2 1/3] media: qcom: camss: Add "gcc_axi_hf" to 8775p VFE lite clock lists Hans de Goede
@ 2026-07-23 11:30 ` Vladimir Zapolskiy
2026-07-23 12:50 ` Loic Poulain
2026-07-23 17:42 ` Cory Keitz
2 siblings, 0 replies; 4+ messages in thread
From: Vladimir Zapolskiy @ 2026-07-23 11:30 UTC (permalink / raw)
To: Hans de Goede, Bryan O'Donoghue, Loic Poulain
Cc: Wenmeng Liu, linux-media, linux-arm-msm, stable
On 7/23/26 14:09, Hans de Goede wrote:
> The "gcc_axi_hf" clock is correctly listed in the clock list of the
> 8775p 2 main VFE-s, but it is missing from all the VFE-lite clock lists,
> causing these to not work on platforms where the firmware allows turning
> off "gcc_axi_hf".
>
> Add the missing "gcc_axi_hf" to fix the VFE-lite blocks not working on
> these platforms.
>
> Fixes: 924f45e58b1fe ("media: qcom: camss: Add missing clocks for VFE lite on sa8775p")
> Cc: stable@vger.kernel.org
> Suggested-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
--
Best wishes,
Vladimir
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/3] media: qcom: camss: Add "gcc_axi_hf" to 8775p VFE lite clock lists
2026-07-23 11:09 [PATCH v2 1/3] media: qcom: camss: Add "gcc_axi_hf" to 8775p VFE lite clock lists Hans de Goede
2026-07-23 11:30 ` Vladimir Zapolskiy
@ 2026-07-23 12:50 ` Loic Poulain
2026-07-23 17:42 ` Cory Keitz
2 siblings, 0 replies; 4+ messages in thread
From: Loic Poulain @ 2026-07-23 12:50 UTC (permalink / raw)
To: Hans de Goede
Cc: Bryan O'Donoghue, Vladimir Zapolskiy, Wenmeng Liu,
linux-media, linux-arm-msm, stable
On Thu, Jul 23, 2026 at 1:09 PM Hans de Goede
<johannes.goede@oss.qualcomm.com> wrote:
>
> The "gcc_axi_hf" clock is correctly listed in the clock list of the
> 8775p 2 main VFE-s, but it is missing from all the VFE-lite clock lists,
> causing these to not work on platforms where the firmware allows turning
> off "gcc_axi_hf".
>
> Add the missing "gcc_axi_hf" to fix the VFE-lite blocks not working on
> these platforms.
>
> Fixes: 924f45e58b1fe ("media: qcom: camss: Add missing clocks for VFE lite on sa8775p")
> Cc: stable@vger.kernel.org
> Suggested-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
Reviewed-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
> ---
> Changes in v2:
> - Also update clock_rate lists
> - Add missing Fixes: tag
> ---
> drivers/media/platform/qcom/camss/camss.c | 25 ++++++++++++++---------
> 1 file changed, 15 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index 2123f6388e3d..68491b16d647 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -4037,10 +4037,11 @@ static const struct camss_subdev_resources vfe_res_8775p[] = {
> /* VFE2 (lite) */
> {
> .regulators = {},
> - .clock = { "cpas_ahb", "cpas_vfe_lite", "vfe_lite_ahb",
> - "vfe_lite_csid", "vfe_lite_cphy_rx",
> + .clock = { "cpas_ahb", "gcc_axi_hf", "cpas_vfe_lite",
> + "vfe_lite_ahb", "vfe_lite_csid", "vfe_lite_cphy_rx",
> "vfe_lite", "camnoc_axi"},
> .clock_rate = {
> + { 0 },
> { 0 },
> { 0 },
> { 300000000, 400000000, 400000000, 400000000 },
> @@ -4062,10 +4063,11 @@ static const struct camss_subdev_resources vfe_res_8775p[] = {
> /* VFE3 (lite) */
> {
> .regulators = {},
> - .clock = { "cpas_ahb", "cpas_vfe_lite", "vfe_lite_ahb",
> - "vfe_lite_csid", "vfe_lite_cphy_rx",
> + .clock = { "cpas_ahb", "gcc_axi_hf", "cpas_vfe_lite",
> + "vfe_lite_ahb", "vfe_lite_csid", "vfe_lite_cphy_rx",
> "vfe_lite", "camnoc_axi"},
> .clock_rate = {
> + { 0 },
> { 0 },
> { 0 },
> { 300000000, 400000000, 400000000, 400000000 },
> @@ -4087,10 +4089,11 @@ static const struct camss_subdev_resources vfe_res_8775p[] = {
> /* VFE4 (lite) */
> {
> .regulators = {},
> - .clock = { "cpas_ahb", "cpas_vfe_lite", "vfe_lite_ahb",
> - "vfe_lite_csid", "vfe_lite_cphy_rx",
> + .clock = { "cpas_ahb", "gcc_axi_hf", "cpas_vfe_lite",
> + "vfe_lite_ahb", "vfe_lite_csid", "vfe_lite_cphy_rx",
> "vfe_lite", "camnoc_axi"},
> .clock_rate = {
> + { 0 },
> { 0 },
> { 0 },
> { 300000000, 400000000, 400000000, 400000000 },
> @@ -4112,10 +4115,11 @@ static const struct camss_subdev_resources vfe_res_8775p[] = {
> /* VFE5 (lite) */
> {
> .regulators = {},
> - .clock = { "cpas_ahb", "cpas_vfe_lite", "vfe_lite_ahb",
> - "vfe_lite_csid", "vfe_lite_cphy_rx",
> + .clock = { "cpas_ahb", "gcc_axi_hf", "cpas_vfe_lite",
> + "vfe_lite_ahb", "vfe_lite_csid", "vfe_lite_cphy_rx",
> "vfe_lite", "camnoc_axi"},
> .clock_rate = {
> + { 0 },
> { 0 },
> { 0 },
> { 300000000, 400000000, 400000000, 400000000 },
> @@ -4137,10 +4141,11 @@ static const struct camss_subdev_resources vfe_res_8775p[] = {
> /* VFE6 (lite) */
> {
> .regulators = {},
> - .clock = { "cpas_ahb", "cpas_vfe_lite", "vfe_lite_ahb",
> - "vfe_lite_csid", "vfe_lite_cphy_rx",
> + .clock = { "cpas_ahb", "gcc_axi_hf", "cpas_vfe_lite",
> + "vfe_lite_ahb", "vfe_lite_csid", "vfe_lite_cphy_rx",
> "vfe_lite", "camnoc_axi"},
> .clock_rate = {
> + { 0 },
> { 0 },
> { 0 },
> { 300000000, 400000000, 400000000, 400000000 },
> --
> 2.55.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/3] media: qcom: camss: Add "gcc_axi_hf" to 8775p VFE lite clock lists
2026-07-23 11:09 [PATCH v2 1/3] media: qcom: camss: Add "gcc_axi_hf" to 8775p VFE lite clock lists Hans de Goede
2026-07-23 11:30 ` Vladimir Zapolskiy
2026-07-23 12:50 ` Loic Poulain
@ 2026-07-23 17:42 ` Cory Keitz
2 siblings, 0 replies; 4+ messages in thread
From: Cory Keitz @ 2026-07-23 17:42 UTC (permalink / raw)
To: Hans de Goede
Cc: Bryan O'Donoghue, Vladimir Zapolskiy, Loic Poulain,
Wenmeng Liu, linux-media, linux-arm-msm, stable
On Thu, Jul 23, 2026 at 01:09:50PM +0200, Hans de Goede wrote:
> The "gcc_axi_hf" clock is correctly listed in the clock list of the
> 8775p 2 main VFE-s, but it is missing from all the VFE-lite clock lists,
> causing these to not work on platforms where the firmware allows turning
> off "gcc_axi_hf".
>
> Add the missing "gcc_axi_hf" to fix the VFE-lite blocks not working on
> these platforms.
Tested-by: Cory Keitz <ckeitz@amazon.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-07-23 17:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-23 11:09 [PATCH v2 1/3] media: qcom: camss: Add "gcc_axi_hf" to 8775p VFE lite clock lists Hans de Goede
2026-07-23 11:30 ` Vladimir Zapolskiy
2026-07-23 12:50 ` Loic Poulain
2026-07-23 17:42 ` Cory Keitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox