Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Abdifatah Suruur <suruurism@gmail.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
	security@kernel.org, Willy Tarreau <w@1wt.eu>,
	stable@vger.kernel.org
Subject: Re: [SECURITY] netfilter: nft_byteorder leaks uninitialised kernel stack on 6.12.y with CONFIG_INIT_STACK_NONE (CWE-457)
Date: Mon, 19 Oct 2026 07:48:48 +0200	[thread overview]
Message-ID: <atWvQFXJzJ434qGd@strlen.de> (raw)
In-Reply-To: <179236182769.4914.3317139682579833845@gmail.com>

Abdifatah Suruur <suruurism@gmail.com> wrote:
> Mainline closed this only as a side effect of bb061d3de4170741 ("netfilter:
> nft_byteorder: remove multi-register support", 2026-05-12), which is marked
> Cc: stable+noautosel and is not in 6.12.y.  Was it left out of stable because
> it is not backportable, or because it was judged not worth backporting?

Because of potential nft -f restore.file failure.
Very unlikely (it requires a buggy nft version trying to load certain
		rules that won't work).

nft 1.1.1 (which has a fix for this...) is now 2 years old though.

I think its fine to backport bb061d3de4170741 to 6.12, but your explicit memset is fine too.

In case stable maintainers prefer the memset:

> Subject: [PATCH] netfilter: nft_byteorder: initialise the marked destination

Acked-by: Florian Westphal <fw@strlen.de>

  reply	other threads:[~2026-10-19  5:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <179235055956.10524.6485282696272965887@gmail.com>
     [not found] ` <atU2brRgmeb6ght2@1wt.eu>
2026-10-18 22:17   ` [SECURITY] netfilter: nft_byteorder leaks uninitialised kernel stack on 6.12.y with CONFIG_INIT_STACK_NONE (CWE-457) Abdifatah Suruur
2026-10-19  5:48     ` Florian Westphal [this message]
2026-10-19  6:08       ` Abdifatah Suruur
2026-10-19  6:58         ` Greg KH
2026-10-19  8:50         ` Pablo Neira Ayuso
2026-10-21 12:47           ` Abdifatah Suruur
2026-10-23 12:57             ` Greg KH
2026-10-23 14:20               ` Abdifatah Suruur
2026-10-22  4:07           ` Abdifatah Suruur
2026-10-19 20:55         ` Sasha Levin
2026-10-19 21:14           ` Florian Westphal
2026-10-21 12:47           ` Abdifatah Suruur
2026-10-22  2:03         ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atWvQFXJzJ434qGd@strlen.de \
    --to=fw@strlen.de \
    --cc=pablo@netfilter.org \
    --cc=security@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=suruurism@gmail.com \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox