* [PATCH v2 1/2] tpm: Track the response read position internally
[not found] <20261120121614.978396-1-rmustafin@cloudlinux.com>
@ 2026-11-20 12:16 ` Rustam Mustafin
2026-11-20 12:27 ` Jarkko Sakkinen
0 siblings, 1 reply; 2+ messages in thread
From: Rustam Mustafin @ 2026-11-20 12:16 UTC (permalink / raw)
To: Peter Huewe, Jarkko Sakkinen
Cc: Jason Gunthorpe, Shuah Khan, Jaewon Yang, linux-integrity,
linux-kselftest, linux-kernel, Rustam Mustafin, stable
tpm_common_read() indexes data_buffer with the caller supplied *off.
A read issued through io_uring reaches the driver with that offset:
loop_rw_iter() passes &ki_pos to ->read(). This allows out-of-bounds
reads and zeroing of kernel memory:
BUG: KASAN: slab-out-of-bounds in _copy_to_user+0x4b/0x70
Read of size 16 by task iou-wrk-148/149
Call Trace:
_copy_to_user+0x4b/0x70
tpm_common_read+0x16e/0x2c0
loop_rw_iter+0x235/0x5a0
__io_read+0xc6e/0x11a0
io_read+0x8a/0x180
A plain read() racing a write() reaches the same access: read()
samples f_pos before taking buffer_mutex, so it can consume a new
response from the offset left by the previous one:
BUG: KASAN: slab-out-of-bounds in _copy_to_user+0x4b/0x70
Read of size 75 by task trigger/151
Call Trace:
_copy_to_user+0x4b/0x70
tpm_common_read+0x16e/0x2c0
vfs_read+0x189/0xc00
ksys_read+0xf9/0x1d0
Replace *off with a read_pos member of struct file_priv. It is only
accessed under buffer_mutex, so the offset passed by the caller no
longer matters.
Fixes: 9488585b21be ("tpm: add support for partial reads")
Cc: stable@vger.kernel.org
Signed-off-by: Rustam Mustafin <rmustafin@cloudlinux.com>
---
drivers/char/tpm/tpm-dev-common.c | 11 ++++++-----
drivers/char/tpm/tpm-dev.h | 1 +
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/char/tpm/tpm-dev-common.c b/drivers/char/tpm/tpm-dev-common.c
index ee91f456f975..553fc6aca94d 100644
--- a/drivers/char/tpm/tpm-dev-common.c
+++ b/drivers/char/tpm/tpm-dev-common.c
@@ -107,6 +107,7 @@ static void tpm_timeout_work(struct work_struct *work)
mutex_lock(&priv->buffer_mutex);
priv->response_read = true;
priv->response_length = 0;
+ priv->read_pos = 0;
memset(priv->data_buffer, 0, sizeof(priv->data_buffer));
mutex_unlock(&priv->buffer_mutex);
wake_up_interruptible(&priv->async_wait);
@@ -149,21 +150,21 @@ ssize_t tpm_common_read(struct file *file, char __user *buf,
goto out;
}
- rc = copy_to_user(buf, priv->data_buffer + *off, ret_size);
+ rc = copy_to_user(buf, priv->data_buffer + priv->read_pos, ret_size);
if (rc) {
memset(priv->data_buffer, 0, TPM_BUFSIZE);
priv->response_length = 0;
ret_size = -EFAULT;
} else {
- memset(priv->data_buffer + *off, 0, ret_size);
+ memset(priv->data_buffer + priv->read_pos, 0, ret_size);
priv->response_length -= ret_size;
- *off += ret_size;
+ priv->read_pos += ret_size;
}
}
out:
if (!priv->response_length) {
- *off = 0;
+ priv->read_pos = 0;
timer_delete_sync(&priv->user_read_timer);
flush = true;
}
@@ -214,7 +215,7 @@ ssize_t tpm_common_write(struct file *file, const char __user *buf,
priv->response_length = 0;
priv->response_read = false;
- *off = 0;
+ priv->read_pos = 0;
/*
* If in nonblocking mode schedule an async job to send
diff --git a/drivers/char/tpm/tpm-dev.h b/drivers/char/tpm/tpm-dev.h
index f3742bcc73e3..34efb1ffa491 100644
--- a/drivers/char/tpm/tpm-dev.h
+++ b/drivers/char/tpm/tpm-dev.h
@@ -15,6 +15,7 @@ struct file_priv {
struct work_struct async_work;
wait_queue_head_t async_wait;
ssize_t response_length;
+ size_t read_pos;
bool response_read;
bool command_enqueued;
--
2.52.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/2] tpm: Track the response read position internally
2026-11-20 12:16 ` [PATCH v2 1/2] tpm: Track the response read position internally Rustam Mustafin
@ 2026-11-20 12:27 ` Jarkko Sakkinen
0 siblings, 0 replies; 2+ messages in thread
From: Jarkko Sakkinen @ 2026-11-20 12:27 UTC (permalink / raw)
To: Rustam Mustafin
Cc: Peter Huewe, Jason Gunthorpe, Shuah Khan, Jaewon Yang,
linux-integrity, linux-kselftest, linux-kernel, stable
On Fri, Nov 20, 2026 at 07:16:13PM +0700, Rustam Mustafin wrote:
> tpm_common_read() indexes data_buffer with the caller supplied *off.
> A read issued through io_uring reaches the driver with that offset:
> loop_rw_iter() passes &ki_pos to ->read(). This allows out-of-bounds
> reads and zeroing of kernel memory:
>
> BUG: KASAN: slab-out-of-bounds in _copy_to_user+0x4b/0x70
> Read of size 16 by task iou-wrk-148/149
> Call Trace:
> _copy_to_user+0x4b/0x70
> tpm_common_read+0x16e/0x2c0
> loop_rw_iter+0x235/0x5a0
> __io_read+0xc6e/0x11a0
> io_read+0x8a/0x180
>
> A plain read() racing a write() reaches the same access: read()
> samples f_pos before taking buffer_mutex, so it can consume a new
> response from the offset left by the previous one:
>
> BUG: KASAN: slab-out-of-bounds in _copy_to_user+0x4b/0x70
> Read of size 75 by task trigger/151
> Call Trace:
> _copy_to_user+0x4b/0x70
> tpm_common_read+0x16e/0x2c0
> vfs_read+0x189/0xc00
> ksys_read+0xf9/0x1d0
>
> Replace *off with a read_pos member of struct file_priv. It is only
> accessed under buffer_mutex, so the offset passed by the caller no
> longer matters.
>
> Fixes: 9488585b21be ("tpm: add support for partial reads")
> Cc: stable@vger.kernel.org
> Signed-off-by: Rustam Mustafin <rmustafin@cloudlinux.com>
> ---
So... why does not this block uring? You are implementing a feature
as a bug fix, or so that it appears.
> drivers/char/tpm/tpm-dev-common.c | 11 ++++++-----
> drivers/char/tpm/tpm-dev.h | 1 +
> 2 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm-dev-common.c b/drivers/char/tpm/tpm-dev-common.c
> index ee91f456f975..553fc6aca94d 100644
> --- a/drivers/char/tpm/tpm-dev-common.c
> +++ b/drivers/char/tpm/tpm-dev-common.c
> @@ -107,6 +107,7 @@ static void tpm_timeout_work(struct work_struct *work)
> mutex_lock(&priv->buffer_mutex);
> priv->response_read = true;
> priv->response_length = 0;
> + priv->read_pos = 0;
> memset(priv->data_buffer, 0, sizeof(priv->data_buffer));
> mutex_unlock(&priv->buffer_mutex);
> wake_up_interruptible(&priv->async_wait);
> @@ -149,21 +150,21 @@ ssize_t tpm_common_read(struct file *file, char __user *buf,
> goto out;
> }
>
> - rc = copy_to_user(buf, priv->data_buffer + *off, ret_size);
> + rc = copy_to_user(buf, priv->data_buffer + priv->read_pos, ret_size);
> if (rc) {
> memset(priv->data_buffer, 0, TPM_BUFSIZE);
> priv->response_length = 0;
> ret_size = -EFAULT;
> } else {
> - memset(priv->data_buffer + *off, 0, ret_size);
> + memset(priv->data_buffer + priv->read_pos, 0, ret_size);
> priv->response_length -= ret_size;
> - *off += ret_size;
> + priv->read_pos += ret_size;
> }
> }
>
> out:
> if (!priv->response_length) {
> - *off = 0;
> + priv->read_pos = 0;
> timer_delete_sync(&priv->user_read_timer);
> flush = true;
> }
> @@ -214,7 +215,7 @@ ssize_t tpm_common_write(struct file *file, const char __user *buf,
>
> priv->response_length = 0;
> priv->response_read = false;
> - *off = 0;
> + priv->read_pos = 0;
>
> /*
> * If in nonblocking mode schedule an async job to send
> diff --git a/drivers/char/tpm/tpm-dev.h b/drivers/char/tpm/tpm-dev.h
> index f3742bcc73e3..34efb1ffa491 100644
> --- a/drivers/char/tpm/tpm-dev.h
> +++ b/drivers/char/tpm/tpm-dev.h
> @@ -15,6 +15,7 @@ struct file_priv {
> struct work_struct async_work;
> wait_queue_head_t async_wait;
> ssize_t response_length;
> + size_t read_pos;
> bool response_read;
> bool command_enqueued;
>
> --
> 2.52.0
>
Br, Jarkko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-20 12:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20261120121614.978396-1-rmustafin@cloudlinux.com>
2026-11-20 12:16 ` [PATCH v2 1/2] tpm: Track the response read position internally Rustam Mustafin
2026-11-20 12:27 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox