Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: silverducks@altlinux.org
Cc: bnatikar@amd.com, Basavaraj.Natikar@amd.com,
	Shyam-sundar.S-k@amd.com, brgl@kernel.org, linusw@kernel.org,
	linux-acpi@vger.kernel.org, linux-gpio@vger.kernel.org,
	mario.limonciello@amd.com, stable@vger.kernel.org,
	westeri@kernel.org
Subject: Re: [PATCH v2] gpiolib: acpi: Add ignore_wake quirk for Gigabyte B650 GAMING X AX
Date: Fri, 20 Nov 2026 16:19:04 +0200	[thread overview]
Message-ID: <awBW2BeZjVdDi_Ha@ashevche-desk.local> (raw)
In-Reply-To: <20261120125823.716828-2-silverducks@altlinux.org>

On Fri, Nov 20, 2026 at 03:58:24PM +0300, silverducks@altlinux.org wrote:
> On 11/19/2026 7:46 PM, Andy Shevchenko wrote:
> > On Thu, Nov 19, 2026 at 03:28:45PM +0300, silverducks@altlinux.org wrote:

...

> >> Hmm... And you are running the latest BIOS?
> >
> >+1. If a newer BIOS de-flags the pin (ExclusiveAndWake -> Exclusive) or
> >stops asserting it in S3, this quirk would permanently disable GPP7 wake
> >on units that no longer need it. Please confirm the BIOS version it
> >reproduces on and whether the latest available BIOS still shows it.
> 
> Ah, right, my bad. The version was F31b.
> I've tested again after flashing the latest F42e (october 20th, checksum
> 1DA1). S3 works on it with unpatched kernels.  Diff of the relevant sections
> between these versions:
> 
> @@ -66279,16 +65498,11 @@
>      {
>          Method (_AEI, 0, NotSerialized)  // _AEI: ACPI Event Interrupts
>          {
> -            Name (BUFF, ResourceTemplate ()
> +            Name (BUFF, Buffer (0x02)
>              {
> -                GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone, 0x0000,
> -                    "\\_SB.GPIO", 0x00, ResourceConsumer, ,
> -                    )
> -                    {   // Pin list
> -                        0x0003
> -                    }
> +                 0x79, 0x00                                       // y.
>              })
> -            Name (BUNP, ResourceTemplate ()
> +            Name (BUNX, ResourceTemplate ()
>              {
>                  GpioInt (Edge, ActiveHigh, ExclusiveAndWake, PullDefault, 0x1388,
>                      "\\_SB.GPIO", 0x00, ResourceConsumer, ,
> 
> @@ -66330,24 +65547,40 @@
>                      "\\_SB.GPIO", 0x00, ResourceConsumer, ,
>                      )
>                      {   // Pin list
> -                        0x0003
> -                    }
> -                GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone, 0x0000,
> -                    "\\_SB.GPIO", 0x00, ResourceConsumer, ,
> -                    )
> -                    {   // Pin list
>                          0x0009
>                      }
>              })
> 
> Seems like this has indeed been fixed on firmware side in the new BIOS.
> Pin 3 was not just deflagged, but removed entirely.
> 
> Should I rescope the quirk to F31b or drop it altogether?

No, since there is a FW update available and it fixes the issue.
However you can do a blog post or something like this, so internet
will remember that.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-11-20 14:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  8:38 [PATCH] gpiolib: acpi: Add ignore_wake quirk for Gigabyte B650 GAMING X AX silverducks
2026-11-19 11:45 ` Andy Shevchenko
2026-11-19 12:28 ` [PATCH v2] " silverducks
2026-11-19 14:16   ` Andy Shevchenko
2026-11-20  6:44     ` Basavaraj Natikar
2026-11-20 12:58       ` silverducks
2026-11-20 14:19         ` Andy Shevchenko [this message]
2026-11-20 14:10       ` Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=awBW2BeZjVdDi_Ha@ashevche-desk.local \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=Basavaraj.Natikar@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=bnatikar@amd.com \
    --cc=brgl@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=silverducks@altlinux.org \
    --cc=stable@vger.kernel.org \
    --cc=westeri@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox