* Re: [PATCH net] dt-bindings: net: sophgo,sg2044-dwmac: Drop status from the example
2025-07-01 6:36 [PATCH net] dt-bindings: net: sophgo,sg2044-dwmac: Drop status from the example Krzysztof Kozlowski
@ 2025-07-01 14:13 ` Alexander Sverdlin
2025-07-01 23:52 ` Chen Wang
2025-07-03 11:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Alexander Sverdlin @ 2025-07-01 14:13 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Chen Wang, Inochi Amaoto, netdev, devicetree,
sophgo, linux-kernel
Cc: stable
On Tue, 2025-07-01 at 08:36 +0200, Krzysztof Kozlowski wrote:
> Examples should be complete and should not have a 'status' property,
> especially a disabled one because this disables the dt_binding_check of
> the example against the schema. Dropping 'status' property shows
> missing other properties - phy-mode and phy-handle.
>
> Fixes: 114508a89ddc ("dt-bindings: net: Add support for Sophgo SG2044 dwmac")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> ---
> Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml b/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml
> index 4dd2dc9c678b..8afbd9ebd73f 100644
> --- a/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml
> @@ -80,6 +80,8 @@ examples:
> interrupt-parent = <&intc>;
> interrupts = <296 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-names = "macirq";
> + phy-handle = <&phy0>;
> + phy-mode = "rgmii-id";
> resets = <&rst 30>;
> reset-names = "stmmaceth";
> snps,multicast-filter-bins = <0>;
> @@ -91,7 +93,6 @@ examples:
> snps,mtl-rx-config = <&gmac0_mtl_rx_setup>;
> snps,mtl-tx-config = <&gmac0_mtl_tx_setup>;
> snps,axi-config = <&gmac0_stmmac_axi_setup>;
> - status = "disabled";
>
> gmac0_mtl_rx_setup: rx-queues-config {
> snps,rx-queues-to-use = <8>;
--
Alexander Sverdlin.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] dt-bindings: net: sophgo,sg2044-dwmac: Drop status from the example
2025-07-01 6:36 [PATCH net] dt-bindings: net: sophgo,sg2044-dwmac: Drop status from the example Krzysztof Kozlowski
2025-07-01 14:13 ` Alexander Sverdlin
@ 2025-07-01 23:52 ` Chen Wang
2025-07-03 11:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Chen Wang @ 2025-07-01 23:52 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Inochi Amaoto, netdev, devicetree, sophgo,
linux-kernel
Cc: stable
On 2025/7/1 14:36, Krzysztof Kozlowski wrote:
> Examples should be complete and should not have a 'status' property,
> especially a disabled one because this disables the dt_binding_check of
> the example against the schema. Dropping 'status' property shows
> missing other properties - phy-mode and phy-handle.
>
> Fixes: 114508a89ddc ("dt-bindings: net: Add support for Sophgo SG2044 dwmac")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Chen Wang <unicorn_wang@outlook.com>
> ---
> Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml b/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml
> index 4dd2dc9c678b..8afbd9ebd73f 100644
> --- a/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml
> @@ -80,6 +80,8 @@ examples:
> interrupt-parent = <&intc>;
> interrupts = <296 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-names = "macirq";
> + phy-handle = <&phy0>;
> + phy-mode = "rgmii-id";
> resets = <&rst 30>;
> reset-names = "stmmaceth";
> snps,multicast-filter-bins = <0>;
> @@ -91,7 +93,6 @@ examples:
> snps,mtl-rx-config = <&gmac0_mtl_rx_setup>;
> snps,mtl-tx-config = <&gmac0_mtl_tx_setup>;
> snps,axi-config = <&gmac0_stmmac_axi_setup>;
> - status = "disabled";
>
> gmac0_mtl_rx_setup: rx-queues-config {
> snps,rx-queues-to-use = <8>;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] dt-bindings: net: sophgo,sg2044-dwmac: Drop status from the example
2025-07-01 6:36 [PATCH net] dt-bindings: net: sophgo,sg2044-dwmac: Drop status from the example Krzysztof Kozlowski
2025-07-01 14:13 ` Alexander Sverdlin
2025-07-01 23:52 ` Chen Wang
@ 2025-07-03 11:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-07-03 11:00 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: andrew+netdev, davem, edumazet, kuba, pabeni, robh, krzk+dt,
conor+dt, unicorn_wang, inochiama, netdev, devicetree, sophgo,
linux-kernel, stable
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Tue, 1 Jul 2025 08:36:22 +0200 you wrote:
> Examples should be complete and should not have a 'status' property,
> especially a disabled one because this disables the dt_binding_check of
> the example against the schema. Dropping 'status' property shows
> missing other properties - phy-mode and phy-handle.
>
> Fixes: 114508a89ddc ("dt-bindings: net: Add support for Sophgo SG2044 dwmac")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> [...]
Here is the summary with links:
- [net] dt-bindings: net: sophgo,sg2044-dwmac: Drop status from the example
https://git.kernel.org/netdev/net/c/f030713e5abf
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread