public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Luca Stefani <luca.stefani.ge1@gmail.com>
To: Jiawei Wang <me@jwang.link>, Mark Brown <broonie@kernel.org>,
	Mukunda Vijendar <vijendar.mukunda@amd.com>,
	Sasha Levin <sashal@kernel.org>
Cc: linux-sound@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 0/2] Revert "ASoC: amd: yc: add new YC platform variant (0x63) support"
Date: Wed, 27 Mar 2024 18:56:18 +0100	[thread overview]
Message-ID: <bc0c1a15-ba31-44ba-85be-273147472240@gmail.com> (raw)
In-Reply-To: <20240312023326.224504-1-me@jwang.link>

Hello everyone,

Can those changes be pulled in stable? They're currently breaking mic 
input on my 21K9CTO1WW, ThinkPad P16s Gen 2, and probably more devices 
in the wild.

Thanks, Luca.

On 12/03/24 03:33, Jiawei Wang wrote:
> Please revert my previous two commits:
>
> ASoC: amd: yc: add new YC platform variant (0x63) support
> [ Upstream commit 316a784839b21b122e1761cdca54677bb19a47fa ]
>
> ASoC: amd: yc: Fix non-functional mic on Lenovo 21J2
> [ Upstream commit ed00a6945dc32462c2d3744a3518d2316da66fcc ]
>
> PCI revision id 0x63 is the Pink Sardine (PS) platform, not Yellow
> Carp (YC). Thanks to Mukunda Vijendar [1] for pointing out that.
>
> The mic on Lenovo 21J2 works after enabling the CONFIG_SND_SOC_AMD_PS
> flag, which I had not enabled when I was writing these patches. 21J2
> does not need to be in this quirk table.
>
> I apologize for the inconvenience caused.
>
> Link: https://lore.kernel.org/linux-sound/023092e1-689c-4b00-b93f-4092c3724fb6@amd.com/ [1]
>
> Signed-off-by: Jiawei Wang <me@jwang.link>
>
> Jiawei Wang (2):
>    Revert "ASoC: amd: yc: Fix non-functional mic on Lenovo 21J2"
>    Revert "ASoC: amd: yc: add new YC platform variant (0x63) support"
>
>   sound/soc/amd/yc/acp6x-mach.c | 7 -------
>   sound/soc/amd/yc/pci-acp6x.c  | 1 -
>   2 files changed, 8 deletions(-)
>

       reply	other threads:[~2024-03-27 17:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240312023326.224504-1-me@jwang.link>
2024-03-27 17:56 ` Luca Stefani [this message]
2024-03-27 18:09   ` [PATCH 0/2] Revert "ASoC: amd: yc: add new YC platform variant (0x63) support" Greg KH
2024-03-28 10:40     ` Mukunda,Vijendar
2024-03-28 11:34       ` Greg KH
2024-03-28 11:57         ` Mukunda,Vijendar
2024-03-29  9:30           ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc0c1a15-ba31-44ba-85be-273147472240@gmail.com \
    --to=luca.stefani.ge1@gmail.com \
    --cc=broonie@kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=me@jwang.link \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=vijendar.mukunda@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox