Re: [PATCH 0/2] Revert "ASoC: amd: yc: add new YC platform variant (0x63) support"

Re: [PATCH 0/2] Revert "ASoC: amd: yc: add new YC platform variant (0x63) support"

[Luca Stefani]

Hello everyone,

Can those changes be pulled in stable? They're currently breaking mic 
input on my 21K9CTO1WW, ThinkPad P16s Gen 2, and probably more devices 
in the wild.

Thanks, Luca.

On 12/03/24 03:33, Jiawei Wang wrote:
> Please revert my previous two commits:
>
> ASoC: amd: yc: add new YC platform variant (0x63) support
> [ Upstream commit 316a784839b21b122e1761cdca54677bb19a47fa ]
>
> ASoC: amd: yc: Fix non-functional mic on Lenovo 21J2
> [ Upstream commit ed00a6945dc32462c2d3744a3518d2316da66fcc ]
>
> PCI revision id 0x63 is the Pink Sardine (PS) platform, not Yellow
> Carp (YC). Thanks to Mukunda Vijendar [1] for pointing out that.
>
> The mic on Lenovo 21J2 works after enabling the CONFIG_SND_SOC_AMD_PS
> flag, which I had not enabled when I was writing these patches. 21J2
> does not need to be in this quirk table.
>
> I apologize for the inconvenience caused.
>
> Link: https://lore.kernel.org/linux-sound/023092e1-689c-4b00-b93f-4092c3724fb6@amd.com/ [1]
>
> Signed-off-by: Jiawei Wang <me@jwang.link>
>
> Jiawei Wang (2):
>    Revert "ASoC: amd: yc: Fix non-functional mic on Lenovo 21J2"
>    Revert "ASoC: amd: yc: add new YC platform variant (0x63) support"
>
>   sound/soc/amd/yc/acp6x-mach.c | 7 -------
>   sound/soc/amd/yc/pci-acp6x.c  | 1 -
>   2 files changed, 8 deletions(-)
>

Re: [PATCH 0/2] Revert "ASoC: amd: yc: add new YC platform variant (0x63) support"

[Greg KH]

On Wed, Mar 27, 2024 at 06:56:18PM +0100, Luca Stefani wrote:
> Hello everyone,
> 
> Can those changes be pulled in stable? They're currently breaking mic input
> on my 21K9CTO1WW, ThinkPad P16s Gen 2, and probably more devices in the
> wild.


<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

Re: [PATCH 0/2] Revert "ASoC: amd: yc: add new YC platform variant (0x63) support"

[Mukunda,Vijendar]

On 27/03/24 23:39, Greg KH wrote:
> On Wed, Mar 27, 2024 at 06:56:18PM +0100, Luca Stefani wrote:
>> Hello everyone,
>>
>> Can those changes be pulled in stable? They're currently breaking mic input
>> on my 21K9CTO1WW, ThinkPad P16s Gen 2, and probably more devices in the
>> wild.
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read:
>     https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
>
> </formletter>
These patches already got merged in V6.9-rc1 release.
Need to be cherry-picked for stable release.

Re: [PATCH 0/2] Revert "ASoC: amd: yc: add new YC platform variant (0x63) support"

[Greg KH]

On Thu, Mar 28, 2024 at 04:10:38PM +0530, Mukunda,Vijendar wrote:
> On 27/03/24 23:39, Greg KH wrote:
> > On Wed, Mar 27, 2024 at 06:56:18PM +0100, Luca Stefani wrote:
> >> Hello everyone,
> >>
> >> Can those changes be pulled in stable? They're currently breaking mic input
> >> on my 21K9CTO1WW, ThinkPad P16s Gen 2, and probably more devices in the
> >> wild.
> >
> > <formletter>
> >
> > This is not the correct way to submit patches for inclusion in the
> > stable kernel tree.  Please read:
> >     https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> > for how to do this properly.
> >
> > </formletter>
> These patches already got merged in V6.9-rc1 release.
> Need to be cherry-picked for stable release.
> 

What changes exactly?  I do not see any git ids here.

confused,

greg k-h

Re: [PATCH 0/2] Revert "ASoC: amd: yc: add new YC platform variant (0x63) support"

[Mukunda,Vijendar]

On 28/03/24 17:04, Greg KH wrote:
> On Thu, Mar 28, 2024 at 04:10:38PM +0530, Mukunda,Vijendar wrote:
>> On 27/03/24 23:39, Greg KH wrote:
>>> On Wed, Mar 27, 2024 at 06:56:18PM +0100, Luca Stefani wrote:
>>>> Hello everyone,
>>>>
>>>> Can those changes be pulled in stable? They're currently breaking mic input
>>>> on my 21K9CTO1WW, ThinkPad P16s Gen 2, and probably more devices in the
>>>> wild.
>>> <formletter>
>>>
>>> This is not the correct way to submit patches for inclusion in the
>>> stable kernel tree.  Please read:
>>>     https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
>>> for how to do this properly.
>>>
>>> </formletter>
>> These patches already got merged in V6.9-rc1 release.
>> Need to be cherry-picked for stable release.
>>
> What changes exactly?  I do not see any git ids here.
>
> confused,
>
> greg k-h

Below are the commits.

37bee1855d0e ASoC: amd: yc: Revert "add new YC platform variant (0x63) support"
861b3415e4de ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"

Re: [PATCH 0/2] Revert "ASoC: amd: yc: add new YC platform variant (0x63) support"

[Greg KH]

On Thu, Mar 28, 2024 at 05:27:58PM +0530, Mukunda,Vijendar wrote:
> On 28/03/24 17:04, Greg KH wrote:
> > On Thu, Mar 28, 2024 at 04:10:38PM +0530, Mukunda,Vijendar wrote:
> >> On 27/03/24 23:39, Greg KH wrote:
> >>> On Wed, Mar 27, 2024 at 06:56:18PM +0100, Luca Stefani wrote:
> >>>> Hello everyone,
> >>>>
> >>>> Can those changes be pulled in stable? They're currently breaking mic input
> >>>> on my 21K9CTO1WW, ThinkPad P16s Gen 2, and probably more devices in the
> >>>> wild.
> >>> <formletter>
> >>>
> >>> This is not the correct way to submit patches for inclusion in the
> >>> stable kernel tree.  Please read:
> >>>     https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> >>> for how to do this properly.
> >>>
> >>> </formletter>
> >> These patches already got merged in V6.9-rc1 release.
> >> Need to be cherry-picked for stable release.
> >>
> > What changes exactly?  I do not see any git ids here.
> >
> > confused,
> >
> > greg k-h
> 
> Below are the commits.
> 
> 37bee1855d0e ASoC: amd: yc: Revert "add new YC platform variant (0x63) support"
> 861b3415e4de ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"
> 
> 
> 

Already asked for here:
	https://lore.kernel.org/r/1b8a991b-ad82-44e6-a76d-a2f81880d549@gmail.com