* [PATCH] loadpin: remove MODULE_COMPRESS_NONE as it is no longer supported
@ 2025-01-13 9:31 Arulpandiyan Vadivel
2025-01-13 10:19 ` Greg KH
2025-01-13 13:42 ` Petr Pavlu
0 siblings, 2 replies; 3+ messages in thread
From: Arulpandiyan Vadivel @ 2025-01-13 9:31 UTC (permalink / raw)
To: linux-security-module
Cc: linux-modules, stable, cedric.hombourger, srikanth.krishnakar,
Arulpandiyan Vadivel
Commit c7ff693fa2094ba0a9d0a20feb4ab1658eff9c33 ("module: Split
modules_install compression and in-kernel decompression") removed the
MODULE_COMPRESS_NONE, but left it loadpin's Kconfig, and removing it
Signed-off-by: Arulpandiyan Vadivel <arulpandiyan.vadivel@siemens.com>
---
security/loadpin/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/loadpin/Kconfig b/security/loadpin/Kconfig
index 848f8b4a60190..94348e2831db9 100644
--- a/security/loadpin/Kconfig
+++ b/security/loadpin/Kconfig
@@ -16,7 +16,7 @@ config SECURITY_LOADPIN_ENFORCE
depends on SECURITY_LOADPIN
# Module compression breaks LoadPin unless modules are decompressed in
# the kernel.
- depends on !MODULES || (MODULE_COMPRESS_NONE || MODULE_DECOMPRESS)
+ depends on !MODULES || MODULE_DECOMPRESS
help
If selected, LoadPin will enforce pinning at boot. If not
selected, it can be enabled at boot with the kernel parameter
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] loadpin: remove MODULE_COMPRESS_NONE as it is no longer supported
2025-01-13 9:31 [PATCH] loadpin: remove MODULE_COMPRESS_NONE as it is no longer supported Arulpandiyan Vadivel
@ 2025-01-13 10:19 ` Greg KH
2025-01-13 13:42 ` Petr Pavlu
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2025-01-13 10:19 UTC (permalink / raw)
To: Arulpandiyan Vadivel
Cc: linux-security-module, linux-modules, stable, cedric.hombourger,
srikanth.krishnakar
On Mon, Jan 13, 2025 at 03:01:15PM +0530, Arulpandiyan Vadivel wrote:
> Commit c7ff693fa2094ba0a9d0a20feb4ab1658eff9c33 ("module: Split
> modules_install compression and in-kernel decompression") removed the
> MODULE_COMPRESS_NONE, but left it loadpin's Kconfig, and removing it
>
> Signed-off-by: Arulpandiyan Vadivel <arulpandiyan.vadivel@siemens.com>
> ---
> security/loadpin/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/loadpin/Kconfig b/security/loadpin/Kconfig
> index 848f8b4a60190..94348e2831db9 100644
> --- a/security/loadpin/Kconfig
> +++ b/security/loadpin/Kconfig
> @@ -16,7 +16,7 @@ config SECURITY_LOADPIN_ENFORCE
> depends on SECURITY_LOADPIN
> # Module compression breaks LoadPin unless modules are decompressed in
> # the kernel.
> - depends on !MODULES || (MODULE_COMPRESS_NONE || MODULE_DECOMPRESS)
> + depends on !MODULES || MODULE_DECOMPRESS
> help
> If selected, LoadPin will enforce pinning at boot. If not
> selected, it can be enabled at boot with the kernel parameter
> --
> 2.39.5
>
>
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] loadpin: remove MODULE_COMPRESS_NONE as it is no longer supported
2025-01-13 9:31 [PATCH] loadpin: remove MODULE_COMPRESS_NONE as it is no longer supported Arulpandiyan Vadivel
2025-01-13 10:19 ` Greg KH
@ 2025-01-13 13:42 ` Petr Pavlu
1 sibling, 0 replies; 3+ messages in thread
From: Petr Pavlu @ 2025-01-13 13:42 UTC (permalink / raw)
To: Arulpandiyan Vadivel
Cc: linux-security-module, linux-modules, stable, cedric.hombourger,
srikanth.krishnakar
On 1/13/25 10:31, Arulpandiyan Vadivel wrote:
> Commit c7ff693fa2094ba0a9d0a20feb4ab1658eff9c33 ("module: Split
> modules_install compression and in-kernel decompression") removed the
> MODULE_COMPRESS_NONE, but left it loadpin's Kconfig, and removing it
>
> Signed-off-by: Arulpandiyan Vadivel <arulpandiyan.vadivel@siemens.com>
Please use a Fixes tag to record the problematic commit:
Fixes: c7ff693fa209 ("module: Split modules_install compression and in-kernel decompression")
> ---
> security/loadpin/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/loadpin/Kconfig b/security/loadpin/Kconfig
> index 848f8b4a60190..94348e2831db9 100644
> --- a/security/loadpin/Kconfig
> +++ b/security/loadpin/Kconfig
> @@ -16,7 +16,7 @@ config SECURITY_LOADPIN_ENFORCE
> depends on SECURITY_LOADPIN
> # Module compression breaks LoadPin unless modules are decompressed in
> # the kernel.
> - depends on !MODULES || (MODULE_COMPRESS_NONE || MODULE_DECOMPRESS)
> + depends on !MODULES || MODULE_DECOMPRESS
> help
> If selected, LoadPin will enforce pinning at boot. If not
> selected, it can be enabled at boot with the kernel parameter
I think this should be updated to:
depends on !MODULES || (!MODULE_COMPRESS || MODULE_DECOMPRESS)
--
Thanks,
Petr
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-01-13 13:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-13 9:31 [PATCH] loadpin: remove MODULE_COMPRESS_NONE as it is no longer supported Arulpandiyan Vadivel
2025-01-13 10:19 ` Greg KH
2025-01-13 13:42 ` Petr Pavlu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox