From: Guenter Roeck <linux@roeck-us.net>
To: David Yang <mmyangfl@gmail.com>
Cc: linux-watchdog@vger.kernel.org, stable@vger.kernel.org,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Jongsung Kim <neidhard.kim@lge.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] watchdog: sp805: re-enable the clock in the restart handler
Date: Sat, 21 Nov 2026 17:28:48 -0800 [thread overview]
Message-ID: <e07b2b4a-514b-4697-b7e4-e2101130f8b2@roeck-us.net> (raw)
In-Reply-To: <20261121204528.2435533-1-mmyangfl@gmail.com>
On Sun, Nov 22, 2026 at 04:45:25AM +0800, David Yang wrote:
> wdt_restart() fail to reboot the system if the watchdog counter clock
> was previously disabled: If userspace cleanly stops the watchdog, the
> core calls wdt_disable() which disables wdt->clk. No reset comes.
>
> Re-enable the clock in it as in npcm_wdt. The watchdog .restart()
> callback runs in atomic context: get the clock with
> devm_clk_get_optional_prepared() at probe time and keep it prepared for
> the lifetime of the driver, so the restart handler only needs
> clk_enable(), which is safe in atomic context.
>
> Link: https://lore.kernel.org/r/20260911031916.A8E051F000FF@smtp.kernel.org
> Fixes: 6c5c0d48b686 ("watchdog: sp805: add restart handler")
> Cc: stable@vger.kernel.org
> Signed-off-by: David Yang <mmyangfl@gmail.com>
Applied.
Thanks,
Guenter
prev parent reply other threads:[~2026-11-22 1:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 20:45 [PATCH v2] watchdog: sp805: re-enable the clock in the restart handler David Yang
2026-11-22 1:28 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e07b2b4a-514b-4697-b7e4-e2101130f8b2@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mmyangfl@gmail.com \
--cc=neidhard.kim@lge.com \
--cc=stable@vger.kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox