Re: [PATCH v3] sched/topology: Enable topology_span_sane check only for debug builds

[Naman Jain <namjain@linux.microsoft.com>]

On 2/5/2025 12:50 PM, K Prateek Nayak wrote:
> Hello Naman,
> 
> On 2/3/2025 5:17 PM, Naman Jain wrote:
>> From: Saurabh Sengar <ssengar@linux.microsoft.com>
>>
>> On a x86 system under test with 1780 CPUs, topology_span_sane() takes

<.>

>>   {
>>       int i = cpu + 1;
>> +    /* Skip the topology sanity check for non-debug, as it is a time- 
>> consuming operatin */
> 
> s/operatin/operation/
> 
>> +    if (!sched_debug()) {
>> +        pr_info_once("%s: Skipping topology span sanity check. Use 
>> `sched_verbose` boot parameter to enable it.\n",
> 
> This could be broken down as follows:
> 
>          pr_info_once("%s: Skipping topology span sanity check."
>                   " Use `sched_verbose` boot parameter to enable it.\n",
>                   __func__);
> 
> Running:
> 
>      grep -r -A 5 "pr_info(.*[^;,]$" kernel/
> 
> gives similar usage across kernel/*. Apart from those nits, feel
> free to add:
> 
> Tested-by: K Prateek Nayak <kprateek.nayak@amd.com> # x86
> 
> if the future version does not change much.
> 

Hello Prateek,
Thanks for reviewing and testing this. I'll make changes based on your
feedback in next version.

Regards,
Naman