From: Takashi Iwai <tiwai@suse.de>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: alsa-devel@alsa-project.org, intel-gfx@lists.freedesktop.org,
stable@vger.kernel.org, Harsha Priya <harshapriya.n@intel.com>,
Emmanuel Jillela <emmanuel.jillela@intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>
Subject: Re: [PATCH] ALSA: hda/hdmi: Disable silent stream on GLK
Date: Sat, 25 Dec 2021 09:17:22 +0100 [thread overview]
Message-ID: <s5h35mhqest.wl-tiwai@suse.de> (raw)
In-Reply-To: <20211222145350.24342-1-ville.syrjala@linux.intel.com>
On Wed, 22 Dec 2021 15:53:50 +0100,
Ville Syrjala wrote:
>
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The silent stream stuff recurses back into i915 audio
> component .get_power() from the .pin_eld_notify() hook.
> On GLK this will deadlock as i915 may already be holding
> the relevant modeset locks during .pin_eld_notify() and
> the GLK audio vs. CDCLK workaround will try to grab the
> same locks from .get_power().
>
> Until someone comes up with a better fix just disable the
> silent stream support on GLK.
>
> Cc: stable@vger.kernel.org
> Cc: Harsha Priya <harshapriya.n@intel.com>
> Cc: Emmanuel Jillela <emmanuel.jillela@intel.com>
> Cc: Kai Vehmanen <kai.vehmanen@linux.intel.com>
> Cc: Takashi Iwai <tiwai@suse.de>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2623
> Fixes: 951894cf30f4 ("ALSA: hda/hdmi: Add Intel silent stream support")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Thanks, applied now.
Takashi
prev parent reply other threads:[~2021-12-25 8:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 14:53 [PATCH] ALSA: hda/hdmi: Disable silent stream on GLK Ville Syrjala
2021-12-22 16:57 ` Kai Vehmanen
2021-12-25 8:17 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h35mhqest.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=emmanuel.jillela@intel.com \
--cc=harshapriya.n@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox