[PATCH 1/2] ALSA: hda - Turn CX8200 into D3 as well upon reboot

[PATCH 1/2] ALSA: hda - Turn CX8200 into D3 as well upon reboot

[Park Ju Hyung]

As an equivalent codec with CX20724,
CX8200 is also subject to the reboot bug.

Late 2017 and 2018 LG Gram and some HP Spectre laptops are known victims
to this issue, causing extremely loud noises upon reboot.

Now that we know that this bug is subject to multiple codecs,
fix the comment as well.

Signed-off-by: Park Ju Hyung <qkrwngud825@gmail.com>
Cc: <stable@vger.kernel.org>
---
 sound/pci/hda/patch_conexant.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
index f641c20095f7..909a880f5e01 100644
--- a/sound/pci/hda/patch_conexant.c
+++ b/sound/pci/hda/patch_conexant.c
@@ -211,6 +211,7 @@ static void cx_auto_reboot_notify(struct hda_codec *codec)
 	struct conexant_spec *spec = codec->spec;
 
 	switch (codec->core.vendor_id) {
+	case 0x14f12008: /* CX8200 */
 	case 0x14f150f2: /* CX20722 */
 	case 0x14f150f4: /* CX20724 */
 		break;
@@ -218,7 +219,7 @@ static void cx_auto_reboot_notify(struct hda_codec *codec)
 		return;
 	}
 
-	/* Turn the CX20722 codec into D3 to avoid spurious noises
+	/* Turn the problematic codec into D3 to avoid spurious noises
 	   from the internal speaker during (and after) reboot */
 	cx_auto_turn_eapd(codec, spec->num_eapds, spec->eapds, false);
 
-- 
2.18.0

Re: [PATCH 1/2] ALSA: hda - Turn CX8200 into D3 as well upon reboot

[Takashi Iwai]

On Fri, 27 Jul 2018 20:16:21 +0200,
Park Ju Hyung wrote:
> 
> As an equivalent codec with CX20724,
> CX8200 is also subject to the reboot bug.
> 
> Late 2017 and 2018 LG Gram and some HP Spectre laptops are known victims
> to this issue, causing extremely loud noises upon reboot.
> 
> Now that we know that this bug is subject to multiple codecs,
> fix the comment as well.
> 
> Signed-off-by: Park Ju Hyung <qkrwngud825@gmail.com>
> Cc: <stable@vger.kernel.org>

Applied, thanks.


Takashi

Re: [PATCH 1/2] ALSA: hda - Turn CX8200 into D3 as well upon reboot

[Ju Hyung Park]

Hi, Greg.

I'd like to know if there's a reason on why these ALSA patches(2 in
total) aren't brought to linux-stable yet.
I see a lot of patches merged to linux-stable and stable-queue that
are much newer than those patches.

I'd appreciate it if you can merge those ASAP.

Thanks,
On Sat, Aug 18, 2018 at 6:17 AM Takashi Iwai <tiwai@suse.de> wrote:
>
> On Fri, 17 Aug 2018 22:40:02 +0200,
> Ju Hyung Park wrote:
> >
> > Hi, I'm still a bit confused.
> >
> > Can I ask why are these patches still yet to appear in linux-stable
> > and stable-queue?
> > I see those are already merged in Torvalds' tree.
>
> Greg has been also busy due to so many patches, give him some time.
> If the patch is still missing in the next release, feel free to ping
> him.
>
>
> Takashi
>
> >
> > Thanks,
> >
> > On Wed, Aug 1, 2018 at 10:14 PM Takashi Iwai <tiwai@suse.de> wrote:
> > >
> > > On Wed, 01 Aug 2018 15:13:21 +0200,
> > > Ju Hyung Park wrote:
> > > >
> > > > On Wed, Aug 1, 2018 at 10:09 PM, Takashi Iwai <tiwai@suse.de> wrote:
> > > > >
> > > > > It's likely postponed to 4.19 unless any critical issue comes up.
> > > > > If it were before rc5, I could push for 4.18, but it's already in a
> > > > > too late stage.  These are no new breakage in 4.18-rc, after all.
> > > >
> > > > Makes sense, but I'd like to see these being pushed to linux-stable ASAP.
> > > >
> > > > Would I have to wait for 4.19-rc1 before that happens?
> > >
> > > Yes.
> > >
> > >
> > > Takashi
> > >
> > > > Thanks.
> > > >
> > > > >
> > > > >
> > > > > thanks,
> > > > >
> > > > > Takashi
> > > > >
> > > > > >
> > > > > > Thanks.
> > > > > >
> > > > > > On Sun, Jul 29, 2018 at 1:58 AM, Takashi Iwai <tiwai@suse.de> wrote:
> > > > > >
> > > > > > > On Fri, 27 Jul 2018 20:16:21 +0200,
> > > > > > > Park Ju Hyung wrote:
> > > > > > > >
> > > > > > > > As an equivalent codec with CX20724,
> > > > > > > > CX8200 is also subject to the reboot bug.
> > > > > > > >
> > > > > > > > Late 2017 and 2018 LG Gram and some HP Spectre laptops are known victims
> > > > > > > > to this issue, causing extremely loud noises upon reboot.
> > > > > > > >
> > > > > > > > Now that we know that this bug is subject to multiple codecs,
> > > > > > > > fix the comment as well.
> > > > > > > >
> > > > > > > > Signed-off-by: Park Ju Hyung <qkrwngud825@gmail.com>
> > > > > > > > Cc: <stable@vger.kernel.org>
> > > > > > >
> > > > > > > Applied, thanks.
> > > > > > >
> > > > > > >
> > > > > > > Takashi
> > > > > > >
> > > > > > [2  <text/html; UTF-8 (quoted-printable)>]
> > > > > >
> > > >
> >

Re: [PATCH 1/2] ALSA: hda - Turn CX8200 into D3 as well upon reboot

[Greg KH]

On Sat, Aug 18, 2018 at 11:29:11PM +0900, Ju Hyung Park wrote:
> Hi, Greg.
> 
> I'd like to know if there's a reason on why these ALSA patches(2 in
> total) aren't brought to linux-stable yet.

What specific patches are you referring to here?  I do not see anything
in this email :(

What is the git commit id in Linus's tree?  What stable tree(s) do you
want them applied to?

> I see a lot of patches merged to linux-stable and stable-queue that
> are much newer than those patches.
> 
> I'd appreciate it if you can merge those ASAP.

Have you read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly?

If not, please do so.

thanks,

greg k-h

Fwd: [PATCH 1/2] ALSA: hda - Turn CX8200 into D3 as well upon reboot

[Ju Hyung Park]

Hi,

It's commit d77a4b4a5b0b2ebcbc9840995d91311ef28302ab
and f59cf9a0551dd954ad8b752461cf19d9789f4b1d,
both which are already merged in Linus's tree.

I can't think of a reason why you would have missed this
other than the fact that I've used "Cc: <stable@vger.kernel.org>"
instead of "Cc: stable@vger.kernel.org".

I doubt it, but would this be the reason?

Thanks,
On Sat, Aug 18, 2018 at 11:38 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Sat, Aug 18, 2018 at 11:29:11PM +0900, Ju Hyung Park wrote:
> > Hi, Greg.
> >
> > I'd like to know if there's a reason on why these ALSA patches(2 in
> > total) aren't brought to linux-stable yet.
>
> What specific patches are you referring to here?  I do not see anything
> in this email :(
>
> What is the git commit id in Linus's tree?  What stable tree(s) do you
> want them applied to?
>
> > I see a lot of patches merged to linux-stable and stable-queue that
> > are much newer than those patches.
> >
> > I'd appreciate it if you can merge those ASAP.
>
> Have you read:
>     https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly?
>
> If not, please do so.
>
> thanks,
>
> greg k-h

Re: Fwd: [PATCH 1/2] ALSA: hda - Turn CX8200 into D3 as well upon reboot

[Greg KH]

On Sun, Aug 19, 2018 at 01:56:22AM +0900, Ju Hyung Park wrote:
> Hi,
> 
> It's commit d77a4b4a5b0b2ebcbc9840995d91311ef28302ab
> and f59cf9a0551dd954ad8b752461cf19d9789f4b1d,
> both which are already merged in Linus's tree.
> 
> I can't think of a reason why you would have missed this
> other than the fact that I've used "Cc: <stable@vger.kernel.org>"
> instead of "Cc: stable@vger.kernel.org".

No, I have not missed these.  I normally wait until a patch shows up in
a release from Linus before adding them to the stable tree, and as these
patches just hit Linus's tree a few days ago, that has not happened yet.
It also is in the middle of over 200 other stable patches that have been
asked to be merged, so you are in good company, and it will take me a
while to get through them all.

I will go add these to the top of the pile, as you have asked about
them, which is fine to do.

thanks,

greg k-h

Fwd: [PATCH 1/2] ALSA: hda - Turn CX8200 into D3 as well upon reboot

[Ju Hyung Park]

Oh, and I forgot to add:
this would better be applied to every stable trees, if applicable
(probably by checking if the commit
f6b28e4ded45bb91bc4cd115d55e35badedfce5f is already merged).

Thanks again.
On Sat, Aug 18, 2018 at 11:38 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Sat, Aug 18, 2018 at 11:29:11PM +0900, Ju Hyung Park wrote:
> > Hi, Greg.
> >
> > I'd like to know if there's a reason on why these ALSA patches(2 in
> > total) aren't brought to linux-stable yet.
>
> What specific patches are you referring to here?  I do not see anything
> in this email :(
>
> What is the git commit id in Linus's tree?  What stable tree(s) do you
> want them applied to?
>
> > I see a lot of patches merged to linux-stable and stable-queue that
> > are much newer than those patches.
> >
> > I'd appreciate it if you can merge those ASAP.
>
> Have you read:
>     https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly?
>
> If not, please do so.
>
> thanks,
>
> greg k-h