SCSI target development
 help / color / mirror / Atom feed
* [PATCH 0/2] infiniband: trivial header search path fixups
@ 2019-01-25  4:39 Masahiro Yamada
  2019-01-25  4:39 ` [PATCH 1/2] infiniband: remove unneeded header search paths Masahiro Yamada
  2019-01-25 22:51 ` [PATCH 0/2] infiniband: trivial header search path fixups Jason Gunthorpe
  0 siblings, 2 replies; 4+ messages in thread
From: Masahiro Yamada @ 2019-01-25  4:39 UTC (permalink / raw)
  To: Jason Gunthorpe, linux-rdma, Doug Ledford
  Cc: Masahiro Yamada, Jason Gunthorpe, Somnath Kotur, Sagi Grimberg,
	Nelson Escobar, Sriharsha Basavapatna, Parvi Kaustubhi,
	linux-kernel, Lijun Ou, Steve Wise, target-devel,
	Christian Benvenuti, Faisal Latif, Bart Van Assche, Shiraz Saleem,
	Selvin Xavier, Wei Hu(Xavier), Devesh Sharma

My main motivation is to get rid of crappy header search path manipulation
from Kbuild core.

Before that, I want to do as many treewide cleanups as possible.

If you are interested in the big picture of this work,
the full patch set is available at:

git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git build-test



Masahiro Yamada (2):
  infiniband: remove unneeded header search paths
  infiniband: prefix header search paths with $(srctree)/

 drivers/infiniband/hw/bnxt_re/Makefile | 2 +-
 drivers/infiniband/hw/cxgb3/Makefile   | 2 +-
 drivers/infiniband/hw/cxgb4/Makefile   | 4 ++--
 drivers/infiniband/hw/hns/Makefile     | 2 +-
 drivers/infiniband/hw/i40iw/Makefile   | 2 +-
 drivers/infiniband/hw/ocrdma/Makefile  | 2 +-
 drivers/infiniband/hw/usnic/Makefile   | 2 +-
 drivers/infiniband/ulp/isert/Makefile  | 1 -
 drivers/infiniband/ulp/srpt/Makefile   | 1 -
 9 files changed, 8 insertions(+), 10 deletions(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] infiniband: remove unneeded header search paths
  2019-01-25  4:39 [PATCH 0/2] infiniband: trivial header search path fixups Masahiro Yamada
@ 2019-01-25  4:39 ` Masahiro Yamada
  2019-01-25  5:27   ` Bart Van Assche
  2019-01-25 22:51 ` [PATCH 0/2] infiniband: trivial header search path fixups Jason Gunthorpe
  1 sibling, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2019-01-25  4:39 UTC (permalink / raw)
  To: Jason Gunthorpe, linux-rdma, Doug Ledford
  Cc: Masahiro Yamada, Jason Gunthorpe, Sagi Grimberg, linux-kernel,
	target-devel, Bart Van Assche

The included headers are located in include/target/. I was able to
build these drivers without the extra header search paths.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/infiniband/ulp/isert/Makefile | 1 -
 drivers/infiniband/ulp/srpt/Makefile  | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/infiniband/ulp/isert/Makefile b/drivers/infiniband/ulp/isert/Makefile
index c8bf242..a4a4766 100644
--- a/drivers/infiniband/ulp/isert/Makefile
+++ b/drivers/infiniband/ulp/isert/Makefile
@@ -1,2 +1 @@
-ccflags-y		:= -Idrivers/target -Idrivers/target/iscsi
 obj-$(CONFIG_INFINIBAND_ISERT)	+= ib_isert.o
diff --git a/drivers/infiniband/ulp/srpt/Makefile b/drivers/infiniband/ulp/srpt/Makefile
index e3ee4bd..43fbde4 100644
--- a/drivers/infiniband/ulp/srpt/Makefile
+++ b/drivers/infiniband/ulp/srpt/Makefile
@@ -1,2 +1 @@
-ccflags-y			:= -Idrivers/target
 obj-$(CONFIG_INFINIBAND_SRPT)	+= ib_srpt.o
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] infiniband: remove unneeded header search paths
  2019-01-25  4:39 ` [PATCH 1/2] infiniband: remove unneeded header search paths Masahiro Yamada
@ 2019-01-25  5:27   ` Bart Van Assche
  0 siblings, 0 replies; 4+ messages in thread
From: Bart Van Assche @ 2019-01-25  5:27 UTC (permalink / raw)
  To: Masahiro Yamada, Jason Gunthorpe, linux-rdma, Doug Ledford
  Cc: Jason Gunthorpe, Sagi Grimberg, linux-kernel, target-devel

On 1/24/19 8:39 PM, Masahiro Yamada wrote:
> The included headers are located in include/target/. I was able to
> build these drivers without the extra header search paths.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
>   drivers/infiniband/ulp/isert/Makefile | 1 -
>   drivers/infiniband/ulp/srpt/Makefile  | 1 -
>   2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/infiniband/ulp/isert/Makefile b/drivers/infiniband/ulp/isert/Makefile
> index c8bf242..a4a4766 100644
> --- a/drivers/infiniband/ulp/isert/Makefile
> +++ b/drivers/infiniband/ulp/isert/Makefile
> @@ -1,2 +1 @@
> -ccflags-y		:= -Idrivers/target -Idrivers/target/iscsi
>   obj-$(CONFIG_INFINIBAND_ISERT)	+= ib_isert.o
> diff --git a/drivers/infiniband/ulp/srpt/Makefile b/drivers/infiniband/ulp/srpt/Makefile
> index e3ee4bd..43fbde4 100644
> --- a/drivers/infiniband/ulp/srpt/Makefile
> +++ b/drivers/infiniband/ulp/srpt/Makefile
> @@ -1,2 +1 @@
> -ccflags-y			:= -Idrivers/target
>   obj-$(CONFIG_INFINIBAND_SRPT)	+= ib_srpt.o

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/2] infiniband: trivial header search path fixups
  2019-01-25  4:39 [PATCH 0/2] infiniband: trivial header search path fixups Masahiro Yamada
  2019-01-25  4:39 ` [PATCH 1/2] infiniband: remove unneeded header search paths Masahiro Yamada
@ 2019-01-25 22:51 ` Jason Gunthorpe
  1 sibling, 0 replies; 4+ messages in thread
From: Jason Gunthorpe @ 2019-01-25 22:51 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: linux-rdma, Doug Ledford, Somnath Kotur, Sagi Grimberg,
	Nelson Escobar, Sriharsha Basavapatna, Parvi Kaustubhi,
	linux-kernel, Lijun Ou, Steve Wise, target-devel,
	Christian Benvenuti, Faisal Latif, Bart Van Assche, Shiraz Saleem,
	Selvin Xavier, Wei Hu(Xavier), Devesh Sharma

On Fri, Jan 25, 2019 at 01:39:29PM +0900, Masahiro Yamada wrote:
> My main motivation is to get rid of crappy header search path manipulation
> from Kbuild core.
> 
> Before that, I want to do as many treewide cleanups as possible.
> 
> If you are interested in the big picture of this work,
> the full patch set is available at:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git build-test
> 
> 
> 
> Masahiro Yamada (2):
>   infiniband: remove unneeded header search paths
>   infiniband: prefix header search paths with $(srctree)/

Still compiles for me too, applied to rdam for-next

Thanks,
Jason

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-01-25 22:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-25  4:39 [PATCH 0/2] infiniband: trivial header search path fixups Masahiro Yamada
2019-01-25  4:39 ` [PATCH 1/2] infiniband: remove unneeded header search paths Masahiro Yamada
2019-01-25  5:27   ` Bart Van Assche
2019-01-25 22:51 ` [PATCH 0/2] infiniband: trivial header search path fixups Jason Gunthorpe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox