* [PATCH v2] hte: replace use of system_unbound_wq with system_dfl_wq
@ 2025-12-24 14:32 Marco Crivellari
2026-01-05 22:34 ` Dipen Patel
0 siblings, 1 reply; 3+ messages in thread
From: Marco Crivellari @ 2025-12-24 14:32 UTC (permalink / raw)
To: linux-kernel, timestamp
Cc: Tejun Heo, Lai Jiangshan, Frederic Weisbecker,
Sebastian Andrzej Siewior, Marco Crivellari, Michal Hocko,
Dipen Patel
This patch continues the effort to refactor workqueue APIs, which has begun
with the changes introducing new workqueues and a new alloc_workqueue flag:
commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")
The point of the refactoring is to eventually alter the default behavior of
workqueues to become unbound by default so that their workload placement is
optimized by the scheduler.
Before that to happen after a careful review and conversion of each individual
case, workqueue users must be converted to the better named new workqueues with
no intended behaviour changes:
system_wq -> system_percpu_wq
system_unbound_wq -> system_dfl_wq
This way the old obsolete workqueues (system_wq, system_unbound_wq) can be
removed in the future.
Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
---
Changes in v2:
- improved commit message
- rebased on v6.19-rc2
---
drivers/hte/hte.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hte/hte.c b/drivers/hte/hte.c
index 23a6eeb8c506..e2804636f2bd 100644
--- a/drivers/hte/hte.c
+++ b/drivers/hte/hte.c
@@ -826,7 +826,7 @@ int hte_push_ts_ns(const struct hte_chip *chip, u32 xlated_id,
ret = ei->cb(data, ei->cl_data);
if (ret == HTE_RUN_SECOND_CB && ei->tcb) {
- queue_work(system_unbound_wq, &ei->cb_work);
+ queue_work(system_dfl_wq, &ei->cb_work);
set_bit(HTE_TS_QUEUE_WK, &ei->flags);
}
--
2.52.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] hte: replace use of system_unbound_wq with system_dfl_wq
2025-12-24 14:32 [PATCH v2] hte: replace use of system_unbound_wq with system_dfl_wq Marco Crivellari
@ 2026-01-05 22:34 ` Dipen Patel
2026-01-07 8:55 ` Marco Crivellari
0 siblings, 1 reply; 3+ messages in thread
From: Dipen Patel @ 2026-01-05 22:34 UTC (permalink / raw)
To: Marco Crivellari, linux-kernel, timestamp
Cc: Tejun Heo, Lai Jiangshan, Frederic Weisbecker,
Sebastian Andrzej Siewior, Michal Hocko
On 12/24/25 6:32 AM, Marco Crivellari wrote:
> This patch continues the effort to refactor workqueue APIs, which has begun
> with the changes introducing new workqueues and a new alloc_workqueue flag:
>
> commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
> commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")
>
> The point of the refactoring is to eventually alter the default behavior of
> workqueues to become unbound by default so that their workload placement is
> optimized by the scheduler.
>
> Before that to happen after a careful review and conversion of each individual
> case, workqueue users must be converted to the better named new workqueues with
> no intended behaviour changes:
>
> system_wq -> system_percpu_wq
> system_unbound_wq -> system_dfl_wq
>
> This way the old obsolete workqueues (system_wq, system_unbound_wq) can be
> removed in the future.
>
> Suggested-by: Tejun Heo <tj@kernel.org>
> Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
> ---
> Changes in v2:
> - improved commit message
> - rebased on v6.19-rc2
> ---
> drivers/hte/hte.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hte/hte.c b/drivers/hte/hte.c
> index 23a6eeb8c506..e2804636f2bd 100644
> --- a/drivers/hte/hte.c
> +++ b/drivers/hte/hte.c
> @@ -826,7 +826,7 @@ int hte_push_ts_ns(const struct hte_chip *chip, u32 xlated_id,
>
> ret = ei->cb(data, ei->cl_data);
> if (ret == HTE_RUN_SECOND_CB && ei->tcb) {
> - queue_work(system_unbound_wq, &ei->cb_work);
> + queue_work(system_dfl_wq, &ei->cb_work);
> set_bit(HTE_TS_QUEUE_WK, &ei->flags);
> }
>
Hi Marco,
Do you want me to pull it in my tree? FYI..I can do it for the next release
cycle i.e. 6.21 timeframe if you want this to be sent through timestamp.
Best Regards,
Dipen Patel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] hte: replace use of system_unbound_wq with system_dfl_wq
2026-01-05 22:34 ` Dipen Patel
@ 2026-01-07 8:55 ` Marco Crivellari
0 siblings, 0 replies; 3+ messages in thread
From: Marco Crivellari @ 2026-01-07 8:55 UTC (permalink / raw)
To: Dipen Patel
Cc: linux-kernel, timestamp, Tejun Heo, Lai Jiangshan,
Frederic Weisbecker, Sebastian Andrzej Siewior, Michal Hocko
On Mon, Jan 5, 2026 at 11:34 PM Dipen Patel <dipenp@nvidia.com> wrote:
> Hi Marco,
>
> Do you want me to pull it in my tree? FYI..I can do it for the next release
> cycle i.e. 6.21 timeframe if you want this to be sent through timestamp.
Hi Dipen,
Yes, it sounds good to me.
Thanks!
--
Marco Crivellari
L3 Support Engineer
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-07 8:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-24 14:32 [PATCH v2] hte: replace use of system_unbound_wq with system_dfl_wq Marco Crivellari
2026-01-05 22:34 ` Dipen Patel
2026-01-07 8:55 ` Marco Crivellari
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox