* [PATCH] hte: Remove redundant dev_err()
@ 2026-07-13 13:29 Pan Chuang
2026-07-15 6:17 ` Mikko Perttunen
0 siblings, 1 reply; 2+ messages in thread
From: Pan Chuang @ 2026-07-13 13:29 UTC (permalink / raw)
To: Dipen Patel, Thierry Reding, Jonathan Hunter,
open list:HTE SUBSYSTEM, open list:TEGRA ARCHITECTURE SUPPORT,
open list
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/hte/hte-tegra194.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/hte/hte-tegra194.c b/drivers/hte/hte-tegra194.c
index 4a7702b32b24..e29fb105ca2d 100644
--- a/drivers/hte/hte-tegra194.c
+++ b/drivers/hte/hte-tegra194.c
@@ -856,10 +856,8 @@ static int tegra_hte_probe(struct platform_device *pdev)
hte_dev->hte_irq = ret;
ret = devm_request_irq(dev, hte_dev->hte_irq, tegra_hte_isr, 0,
dev_name(dev), hte_dev);
- if (ret < 0) {
- dev_err(dev, "request irq failed.\n");
+ if (ret < 0)
return ret;
- }
gc->nlines = nlines;
gc->ops = &g_ops;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hte: Remove redundant dev_err()
2026-07-13 13:29 [PATCH] hte: Remove redundant dev_err() Pan Chuang
@ 2026-07-15 6:17 ` Mikko Perttunen
0 siblings, 0 replies; 2+ messages in thread
From: Mikko Perttunen @ 2026-07-15 6:17 UTC (permalink / raw)
To: Dipen Patel, Thierry Reding, Jonathan Hunter,
open list:HTE SUBSYSTEM, open list:TEGRA ARCHITECTURE SUPPORT,
open list, Pan Chuang
Cc: Pan Chuang
On Monday, July 13, 2026 10:29 PM Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---
> drivers/hte/hte-tegra194.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/hte/hte-tegra194.c b/drivers/hte/hte-tegra194.c
> index 4a7702b32b24..e29fb105ca2d 100644
> --- a/drivers/hte/hte-tegra194.c
> +++ b/drivers/hte/hte-tegra194.c
> @@ -856,10 +856,8 @@ static int tegra_hte_probe(struct platform_device *pdev)
> hte_dev->hte_irq = ret;
> ret = devm_request_irq(dev, hte_dev->hte_irq, tegra_hte_isr, 0,
> dev_name(dev), hte_dev);
> - if (ret < 0) {
> - dev_err(dev, "request irq failed.\n");
> + if (ret < 0)
> return ret;
> - }
>
> gc->nlines = nlines;
> gc->ops = &g_ops;
> --
> 2.34.1
>
>
I suppose 'hte: tegra194: ' would be more appropriate, but it's the
only driver under hte anyway.
Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-15 6:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-13 13:29 [PATCH] hte: Remove redundant dev_err() Pan Chuang
2026-07-15 6:17 ` Mikko Perttunen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox