* [PATCH b4] review-tui: show no-reply preview for note-only reviews
@ 2026-08-25 18:08 Jason Gunthorpe
2026-08-25 21:09 ` Konstantin Ryabitsev
0 siblings, 1 reply; 2+ messages in thread
From: Jason Gunthorpe @ 2026-08-25 18:08 UTC (permalink / raw)
To: tools
If a note is attached and nothing else is placed in the review then the
email screen says:
No email to preview (missing message-id?).
Which sounds like an error, really there is no message to send so it
should say:
No reply will be sent for this patch.
Remove note from the condition.
Assisted-by: LLM
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
---
src/b4/review_tui/_review_app.py | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/src/b4/review_tui/_review_app.py b/src/b4/review_tui/_review_app.py
index 7fe707bb8995f1..d73fe057b5d499 100644
--- a/src/b4/review_tui/_review_app.py
+++ b/src/b4/review_tui/_review_app.py
@@ -854,10 +854,7 @@ class ReviewApp(LoreNodeShutdownMixin, CheckRunnerMixin, App[None]):
return
if not review or not (
- review.get('trailers')
- or review.get('reply', '')
- or review.get('comments')
- or review.get('note', '')
+ review.get('trailers') or review.get('reply', '') or review.get('comments')
):
viewer.write('[dim]No reply will be sent for this patch.[/dim]')
return
base-commit: 064bdaa79218f23790cf5792ed87f961e8681555
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-25 21:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-25 18:08 [PATCH b4] review-tui: show no-reply preview for note-only reviews Jason Gunthorpe
2026-08-25 21:09 ` Konstantin Ryabitsev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox