From: "Mark Brown" <broonie@kernel.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: tools@linux.kernel.org
Subject: Re: [kernel.org users] b4 auto-thankanator landed in master
Date: Wed, 15 Apr 2020 19:32:48 +0100 [thread overview]
Message-ID: <20200415183248.GK5265@sirena.org.uk> (raw)
In-Reply-To: <20200415175548.h4tyddairbltmri3@chatter.i7.local>
[-- Attachment #1: Type: text/plain, Size: 1312 bytes --]
On Wed, Apr 15, 2020 at 01:55:48PM -0400, Konstantin Ryabitsev wrote:
> On Wed, Apr 15, 2020 at 06:23:24PM +0100, Mark Brown wrote:
> > I think there's still some issue, not sure what triggers it but it seems
> > to happen with explicitly specified messages too. Do I need to clear
> > out some local database?
> No, this means we're getting an output that I'm not expecting. Could you
> please rerun that as "b4 -d" to enable debug output? Right before it
> crashes, it should print out a line like this:
> Running git --no-pager diff ...
> I'd be very interested to see the diff that is produced by running that
> command (specifically, the @@ @@ lines). That code currently expects to
> always have lines added and lines removed, but that appears to be the
> wrong expectation and I need to fix that.
Running git --no-pager diff d2a66a4f85813d53fa5618f95e365a4f3beb2aa3~..d2a66a4f85813d53fa5618f95e365a4f3beb2aa3
is the one immediately before it explodes. That's a local commit in my
tree which I'm reluctant to share but playing about a bit I'm pretty
sure that the issue is that the only thing it does is add a file - the
one @@ line is:
@@ -0,0 +1 @@
and I can reproduce similar behaviour with other random one line
additions. Does that help you see the issue?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 499 bytes --]
next prev parent reply other threads:[~2020-04-15 18:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 21:00 b4 auto-thankanator landed in master Konstantin Ryabitsev
2020-04-15 15:00 ` [kernel.org users] " Mark Brown
2020-04-15 16:57 ` Konstantin Ryabitsev
2020-04-15 17:23 ` Mark Brown
2020-04-15 17:55 ` Konstantin Ryabitsev
2020-04-15 18:32 ` Mark Brown [this message]
2020-04-15 19:28 ` Konstantin Ryabitsev
2020-04-15 20:12 ` Mark Brown
2020-04-15 21:21 ` Konstantin Ryabitsev
2020-04-15 21:40 ` Mark Brown
2020-04-15 22:36 ` Konstantin Ryabitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415183248.GK5265@sirena.org.uk \
--to=broonie@kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox