Re: [kernel.org users] b4 auto-thankanator landed in master

["Mark Brown" <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1687 bytes --]

On Wed, Apr 15, 2020 at 03:28:19PM -0400, Konstantin Ryabitsev wrote:
> On Wed, Apr 15, 2020 at 07:32:48PM +0100, Mark Brown wrote:

> > and I can reproduce similar behaviour with other random one line
> > additions.  Does that help you see the issue?

> Yes, we always expect there to be a N,N in that output, which isn't true 
> in a number of scenarios (like a commit that creates a new file with 
> only one line).

> The latest master should properly deal with this situation (as well as 
> when a patch deletes all lines from a file).

Did you forget to push...

> Glad you ran across this, as this affects attestation as well. Looks 
> like I'll need to backport that to 0.3.y.

...I'm seeing a relevant update on 0.3.y but master has c4469dc30c30f6
(Keep track of how many messages we create) as the head still.

I also noticed a couple of other issues.

One is that if I try to specify a remote branch with 'b4 ty -s all -b
remote/foo' or whatever b4 doesn't think the branch exists.  I'm doing
this because I want to be sure I only send out thank you mails for
things that actually got pushed successfully (in the past I've found
people get confused if the thanks arrives and they can't see the
published commit).  It needs a --remote on the git branch command line.

The other is that if I don't apply all of a series then b4 ty will
refuse to generate anything with no way I can see to override.  This
happens a fair amount when people do things like send a new driver along
with a DT update.  Perhaps an option to allow partial lists (though I
think that might need more complex templating), or one to generate
per-patch thanks messages?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 499 bytes --]