b4 ty doesn't respect -b for prs

b4 ty doesn't respect -b for prs

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 656 bytes --]

Hi Konstantin,

When I run b4 ty to generate thank-you letters for a pull specifying -b
the program doesn't find the merge commit:

  $ b4 ty -b asoc-5.7 -s 2
  Generating 1 thank-you letters
  Could not get merge commit id for [GIT PULL] ASoC: tegra: Fixes for v5.7-rc3
  Was it actually merged?

however if I change to the branch it does:

  $ git checkout asoc-5.7
  Switched to branch 'asoc-5.7'
  $ b4 ty -b asoc-5.7 -s 2
  Generating 1 thank-you letters
  Writing: ./thierry_reding_gmail_com_git_pull_asoc_tegra_fixes_for_v5_7_rc3.thanks

(asoc-5.7 is for-5.7 in my sound tree, the merge commit is now published.)

Thanks,
Mark

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 499 bytes --]

Re: b4 ty doesn't respect -b for prs

[Konstantin Ryabitsev]

On Wed, Apr 22, 2020 at 03:06:37PM +0100, Mark Brown wrote:
> When I run b4 ty to generate thank-you letters for a pull specifying 
> -b
> the program doesn't find the merge commit:
> 
>   $ b4 ty -b asoc-5.7 -s 2
>   Generating 1 thank-you letters
>   Could not get merge commit id for [GIT PULL] ASoC: tegra: Fixes for v5.7-rc3
>   Was it actually merged?
> 
> however if I change to the branch it does:
> 
>   $ git checkout asoc-5.7
>   Switched to branch 'asoc-5.7'
>   $ b4 ty -b asoc-5.7 -s 2
>   Generating 1 thank-you letters
>   Writing: ./thierry_reding_gmail_com_git_pull_asoc_tegra_fixes_for_v5_7_rc3.thanks

Good find -- there is a fix for this in master.

> (asoc-5.7 is for-5.7 in my sound tree, the merge commit is now 
> published.)

I see that your message says "undefined" here:
https://lore.kernel.org/alsa-devel/158756395814.23495.171205742201395813.b4-ty@kernel.org/

I'll see if I can find something nicer for it to say instead.

-K

Re: b4 ty doesn't respect -b for prs

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 840 bytes --]

On Wed, Apr 22, 2020 at 06:43:45PM -0400, Konstantin Ryabitsev wrote:
> On Wed, Apr 22, 2020 at 03:06:37PM +0100, Mark Brown wrote:

> >   Generating 1 thank-you letters
> >   Writing: ./thierry_reding_gmail_com_git_pull_asoc_tegra_fixes_for_v5_7_rc3.thanks

> Good find -- there is a fix for this in master.

Thanks.

> > (asoc-5.7 is for-5.7 in my sound tree, the merge commit is now 
> > published.)

> I see that your message says "undefined" here:
> https://lore.kernel.org/alsa-devel/158756395814.23495.171205742201395813.b4-ty@kernel.org/

> I'll see if I can find something nicer for it to say instead.

I'm not sure there's something fundamentally better - it's basically
"local tree" and not all of my local branches are tagged as tracking
branches in git.  Should've proofread properly before I sent it out.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 499 bytes --]

Re: b4 ty doesn't respect -b for prs

[Konstantin Ryabitsev]

On Thu, Apr 23, 2020 at 11:17:33AM +0100, Mark Brown wrote:
> > > (asoc-5.7 is for-5.7 in my sound tree, the merge commit is now 
> > > published.)
> 
> > I see that your message says "undefined" here:
> > https://lore.kernel.org/alsa-devel/158756395814.23495.171205742201395813.b4-ty@kernel.org/
> 
> > I'll see if I can find something nicer for it to say instead.
> 
> I'm not sure there's something fundamentally better - it's basically
> "local tree" and not all of my local branches are tagged as tracking
> branches in git.  Should've proofread properly before I sent it out.

Well, even if it says "local tree" as the fallback default for 
${treename}, that will be more informative than "undefined". That's what 
I'll probably set it to.

-K