Re: b4 submit ready for beta testing

[Jason Gunthorpe <jgg@ziepe.ca>]

On Mon, Jul 18, 2022 at 02:38:48PM +0200, Paolo Bonzini wrote:
> On 7/18/22 10:49, Maxime Ripard wrote:
> > > 
> > > One thing to keep in mind here is that actual trailer matching is done by
> > > comparing the patch-id (see git-patch-id for details). This has the following
> > > important bonuses and caveats:
> > > 
> > >    - You can rearrange patches or modify summaries without it affecting the
> > >      match.
> > >    - If you modify actual code (even as much as fixing a typo in a string), any
> > >      received trailers will no longer match. This is as designed, because if
> > >      you change the code, it's no longer reviewed (but we won't remove any
> > >      existing trailers that were already applied).

IMHO, I don't like this. It means even minor changes that don't
invalidate a given "reviewed-by" will not be taken. It should only be
up to the user to make these decisions when tags should be dropped.

> > >    - when you use --signoff, this will move your own "Signed-off-by" trailer
> > >      below any other trailers in all series commits, which is commonly
> > >      recommended for the chain-of-custody purposes.
> > Ok, that part is really awesome:)
> 
> Yeah, and it's the part that I'd like to have as a standalone tool in b4.
> Can we have some kind of "b4 update-trailers <MSGID>" subcommand?

+1

Updating trailers by hand is a PITA..

Jason