From: Jason Gunthorpe <jgg@ziepe.ca>
To: Junio C Hamano <gitster@pobox.com>
Cc: Linus Torvalds <torvalds@linuxfoundation.org>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
users@linux.kernel.org, tools@linux.kernel.org
Subject: Re: b4 submit ready for beta testing
Date: Wed, 20 Jul 2022 21:02:56 -0300 [thread overview]
Message-ID: <20220721000256.GS5049@ziepe.ca> (raw)
In-Reply-To: <CAPc5daWCm=8Bket5t9Q+SJ+6pRL3PPSYVqU3Z98miKV+D_bFFQ@mail.gmail.com>
On Wed, Jul 20, 2022 at 04:42:44PM -0700, Junio C Hamano wrote:
> On Wed, Jul 20, 2022 at 4:41 PM Linus Torvalds <torvalds@linuxfoundation.org> wrote:
> >
> > On Wed, Jul 20, 2022 at 4:39 PM Jason Gunthorpe <jgg@ziepe.ca> wrote:
> > >
> > > If the cover letter is the last commit then 'git commit --amend'
> > > allows editing it as easily as 'git branch --edit description'.
> >
> > .. and what about adding new commits during development?
> >
> > That sounds oh-so-*very* inconvenient.
>
> "git rebase -i" is your friend ;-)
Yeah, exactly.
New commits are not even that likely to be added at the end of the
series anyhow. A new commit needs to be added at the logical place it
belongs in the sequence, so someone should already be proficient using
rebase to shuffle commit order around.
Either write the commit at the end and 'rebase -i' it into place, or
'rebase -i' with "edit" to directly author it where it belongs.
An empty commit is trivial to reorder with 'rebase -i' - guarenteed no
conflicts :)
And when there are issues in the commits I generally end up with
fixup! commits and repeated "rebase -i --autosquash"'s until the
series is done.
I'm getting the impression that people are building series in git
without using a lot of 'rebase -i' ? How is this done ?
Jason
next prev parent reply other threads:[~2022-07-21 0:02 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-16 14:29 b4 submit ready for beta testing Konstantin Ryabitsev
2022-07-16 14:43 ` James Bottomley
2022-07-16 14:56 ` Konstantin Ryabitsev
2022-07-16 16:10 ` Junio C Hamano
2022-07-16 16:55 ` James Bottomley
2022-07-16 17:14 ` Conor Dooley
2022-07-17 15:43 ` Konstantin Ryabitsev
2022-07-18 18:14 ` Jason Gunthorpe
2022-07-18 18:34 ` Luck, Tony
2022-07-17 16:02 ` Konstantin Ryabitsev
2022-07-18 18:17 ` Jason Gunthorpe
2022-07-18 20:28 ` Geert Uytterhoeven
2022-07-18 23:10 ` Jason Gunthorpe
2022-07-19 7:02 ` Geert Uytterhoeven
2022-07-19 12:09 ` Mark Brown
2022-07-19 12:28 ` Geert Uytterhoeven
2022-07-20 13:06 ` Sudeep Holla
2022-07-19 12:44 ` James Bottomley
2022-07-19 12:51 ` Geert Uytterhoeven
2022-07-19 13:11 ` Michael S. Tsirkin
2022-07-19 14:14 ` Mark Brown
2022-07-19 12:34 ` Jason Gunthorpe
2022-07-19 12:47 ` Geert Uytterhoeven
2022-07-19 13:00 ` Jason Gunthorpe
2022-07-19 13:16 ` Geert Uytterhoeven
2022-07-19 13:59 ` Maxime Ripard
2022-07-19 15:32 ` Jason Gunthorpe
2022-07-19 16:07 ` Konstantin Ryabitsev
2022-07-19 16:18 ` Rob Herring
2022-07-19 13:01 ` James Bottomley
2022-07-19 15:34 ` Jason Gunthorpe
2022-07-19 15:38 ` James Bottomley
2022-07-19 15:47 ` Jason Gunthorpe
2022-07-25 12:16 ` Michael S. Tsirkin
2022-07-17 9:58 ` Geert Uytterhoeven
2022-07-17 15:40 ` Konstantin Ryabitsev
2022-07-18 8:49 ` Maxime Ripard
2022-07-18 12:38 ` Paolo Bonzini
2022-07-18 18:20 ` Jason Gunthorpe
2022-07-18 18:26 ` Konstantin Ryabitsev
2022-07-18 14:33 ` Konstantin Ryabitsev
2022-07-18 15:15 ` Maxime Ripard
2022-07-18 17:15 ` Rob Herring
2022-07-18 18:23 ` Konstantin Ryabitsev
2022-07-19 12:23 ` Mattijs Korpershoek
2022-07-19 13:09 ` Konstantin Ryabitsev
2022-07-20 18:48 ` Konstantin Ryabitsev
2022-07-20 19:24 ` Jason Gunthorpe
2022-07-20 19:40 ` Konstantin Ryabitsev
2022-07-20 19:55 ` Jason Gunthorpe
2022-07-20 20:06 ` Konstantin Ryabitsev
2022-07-20 23:13 ` Junio C Hamano
2022-07-20 23:23 ` Linus Torvalds
2022-07-20 23:39 ` Jason Gunthorpe
2022-07-20 23:40 ` Linus Torvalds
2022-07-20 23:42 ` Junio C Hamano
2022-07-21 0:02 ` Jason Gunthorpe [this message]
2022-07-21 0:54 ` Theodore Ts'o
2022-07-21 2:31 ` Dave Chinner
2022-07-21 13:07 ` Jason Gunthorpe
2022-07-21 22:49 ` Dave Chinner
2022-07-22 9:10 ` Geert Uytterhoeven
2022-07-21 8:48 ` Geert Uytterhoeven
2022-07-21 13:08 ` Jason Gunthorpe
2022-07-26 8:37 ` Mattijs Korpershoek
2022-07-26 13:55 ` Paolo Bonzini
2022-07-26 14:06 ` Konstantin Ryabitsev
2022-07-26 14:27 ` Konstantin Ryabitsev
2022-07-26 14:54 ` Mattijs Korpershoek
2022-07-26 20:56 ` Konstantin Ryabitsev
2022-08-18 19:30 ` Conor Dooley
2022-08-18 20:12 ` Conor Dooley
2022-08-18 21:04 ` Konstantin Ryabitsev
2022-08-18 21:22 ` Conor Dooley
2022-08-19 20:43 ` Konstantin Ryabitsev
2022-08-19 21:00 ` Conor Dooley
2022-07-26 13:11 ` Mattijs Korpershoek
2022-07-26 14:37 ` Konstantin Ryabitsev
2022-07-28 16:04 ` Maxime Ripard
2022-07-28 16:24 ` Konstantin Ryabitsev
2022-08-15 16:17 ` Maxime Ripard
2022-08-15 17:05 ` Konstantin Ryabitsev
2022-08-16 7:39 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220721000256.GS5049@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=gitster@pobox.com \
--cc=konstantin@linuxfoundation.org \
--cc=tools@linux.kernel.org \
--cc=torvalds@linuxfoundation.org \
--cc=users@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox