[PATCH b4] setup.py: bump python_requires to 3.8

[PATCH b4] setup.py: bump python_requires to 3.8

[Philippe Blain]

Since c95e4d1 (am: Fix broken guessbranch handling, 2022-03-31), b4 uses
the 'extend' action for the '--guess-branch' argument. This action is
new in Python 3.8 [1], but setup.py still lists Python 3.6 as the
minimum version.

This leads Pip to allow installing or upgrading b4 on Python 3.6 or 3.7,
but then any invocation of b4 fails with an error from the argparse
module ending with:

    ValueError: unknown action "extend"

Fix this by bumping python_requires to 3.8.

[1] https://docs.python.org/3/library/argparse.html#action

Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com>
---
 setup.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/setup.py b/setup.py
index 1565f30..458b135 100644
--- a/setup.py
+++ b/setup.py
@@ -46,7 +46,7 @@ setup(
         'dkimpy>=1.0,<2.0',
         'patatt>=0.5,<2.0',
     ],
-    python_requires='>=3.6',
+    python_requires='>=3.8',
     entry_points={
         'console_scripts': [
             'b4=b4.command:cmd'

base-commit: e107170fc17e3e2effb6a1629a8658497f59375b
-- 
2.29.2

Re: [PATCH b4] setup.py: bump python_requires to 3.8

[Konstantin Ryabitsev]

On Tue, 23 Aug 2022 23:05:26 -0400, Philippe Blain wrote:
> Since c95e4d1 (am: Fix broken guessbranch handling, 2022-03-31), b4 uses
> the 'extend' action for the '--guess-branch' argument. This action is
> new in Python 3.8 [1], but setup.py still lists Python 3.6 as the
> minimum version.
> 
> This leads Pip to allow installing or upgrading b4 on Python 3.6 or 3.7,
> but then any invocation of b4 fails with an error from the argparse
> module ending with:
> 
> [...]

Applied, thanks!

[1/1] setup.py: bump python_requires to 3.8
      commit: 65ba7a9d3ee989035a875e7c108f1733e92c7ea0

Best regards,
-- 
Konstantin Ryabitsev <konstantin@linuxfoundation.org>

Re: [PATCH b4] setup.py: bump python_requires to 3.8

[Philippe Blain]

Hi Konstantin,

Le 2022-08-24 à 10:01, Konstantin Ryabitsev a écrit :
> On Tue, 23 Aug 2022 23:05:26 -0400, Philippe Blain wrote:
>> Since c95e4d1 (am: Fix broken guessbranch handling, 2022-03-31), b4 uses
>> the 'extend' action for the '--guess-branch' argument. This action is
>> new in Python 3.8 [1], but setup.py still lists Python 3.6 as the
>> minimum version.
>>
>> This leads Pip to allow installing or upgrading b4 on Python 3.6 or 3.7,
>> but then any invocation of b4 fails with an error from the argparse
>> module ending with:
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/1] setup.py: bump python_requires to 3.8
>       commit: 65ba7a9d3ee989035a875e7c108f1733e92c7ea0
> 
> Best regards,
> 

Super! Would it make sense to merge it to stable-0.9.y and create 
a new release ? This would avoid the problem for people upgrading or installing
on 3.6 or 3.7, without waiting for 0.10.0 to be released.

Philippe.

Re: [PATCH b4] setup.py: bump python_requires to 3.8

[Konstantin Ryabitsev]

On Wed, Aug 24, 2022 at 10:10:35AM -0400, Philippe Blain wrote:
> > Applied, thanks!
> > 
> > [1/1] setup.py: bump python_requires to 3.8
> >       commit: 65ba7a9d3ee989035a875e7c108f1733e92c7ea0
> > 
> > Best regards,
> > 
> 
> Super! Would it make sense to merge it to stable-0.9.y and create 
> a new release ? This would avoid the problem for people upgrading or installing
> on 3.6 or 3.7, without waiting for 0.10.0 to be released.

Correct, I did apply it to stable-0.9.y (pushed now). I should have noticed
the incompatible option, but on the other hand 3.6 is EOL since December last
year, so everyone needs to move on to something newer anyway.

I'll see if there are some other backports worth doing for 0.9 and then
release a 0.9.1.

Thanks,
-K