"b4 am" quotes parens in S-o-b lines

"b4 am" quotes parens in S-o-b lines

[Matthew Wilcox]

Quick example:

$ b4 am 20231012195415.282357-1-willy@infradead.org
$ grep Signed ./20231012_willy_allow_nesting_of_lazy_mmu_mode.mbx
Signed-off-by: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Signed-off-by: "Matthew Wilcox (Oracle)" <willy@infradead.org>

The quote marks do not appear in the original emails, eg
https://lore.kernel.org/all/20231012195415.282357-2-willy@infradead.org/

Adding the quotes around the name is not needed; I have many commits
in Linux without the quote marks.

Thanks!

Re: "b4 am" quotes parens in S-o-b lines

[Konstantin Ryabitsev]

On Mon, Oct 16, 2023 at 08:37:39PM +0100, Matthew Wilcox wrote:
> Quick example:
> 
> $ b4 am 20231012195415.282357-1-willy@infradead.org
> $ grep Signed ./20231012_willy_allow_nesting_of_lazy_mmu_mode.mbx
> Signed-off-by: "Matthew Wilcox (Oracle)" <willy@infradead.org>
> Signed-off-by: "Matthew Wilcox (Oracle)" <willy@infradead.org>
> 
> The quote marks do not appear in the original emails, eg
> https://lore.kernel.org/all/20231012195415.282357-2-willy@infradead.org/
> 
> Adding the quotes around the name is not needed; I have many commits
> in Linux without the quote marks.

It's a regression due to switching to the same code that does actual email
headers (where quote-escaping is needed for special chars like commas and
parentheses). It's not needed for git trailers, so we'll need separate
handling for thise cases.

bugbot assign to me

-K

Re: "b4 am" quotes parens in S-o-b lines

[Kernel.org Bugbot]

Hello:

This conversation is now tracked by Kernel.org Bugzilla:
https://bugzilla.kernel.org/show_bug.cgi?id=218017

There is no need to do anything else, just keep talking.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (peebz 0.1)

Re: "b4 am" quotes parens in S-o-b lines

[Kernel.org Bugbot]

Konstantin Ryabitsev writes in commit 26615095533f901d9cbf9eb599f4dc5e305f5036:

trailers: do not quote names when special chars are present

When fixing potential email address rendering problems, we do not need
to be as stringent about the contents of the git trailer as when we are
dealing with actual email headers. For example, we do not need to quote
names containing things like commas or parentheses.

Reported-by: Matthew Wilcox <willy@infradead.org>
Fixes: 832010c4d50 ("trailers: normalize address after parsing")
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218017
Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>

(via https://git.kernel.org/pub/scm/utils/b4/b4.git/commit/?id=26615095533f)
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (peebz 0.1)

Re: "b4 am" quotes parens in S-o-b lines

[Matthew Wilcox]

On Mon, Oct 16, 2023 at 08:35:22PM +0000, Kernel.org Bugbot wrote:
> Konstantin Ryabitsev writes in commit 26615095533f901d9cbf9eb599f4dc5e305f5036:
> 
> trailers: do not quote names when special chars are present
> 
> When fixing potential email address rendering problems, we do not need
> to be as stringent about the contents of the git trailer as when we are
> dealing with actual email headers. For example, we do not need to quote
> names containing things like commas or parentheses.
> 
> Reported-by: Matthew Wilcox <willy@infradead.org>

Surely that should be ...

Reported-by: Matthew Wilcox (Oracle) <willy@infradead.org>

;-)

Thanks for the quick fix!

Re: "b4 am" quotes parens in S-o-b lines

[Vlastimil Babka]

On 10/17/23 05:03, Matthew Wilcox wrote:
> On Mon, Oct 16, 2023 at 08:35:22PM +0000, Kernel.org Bugbot wrote:
>> Konstantin Ryabitsev writes in commit 26615095533f901d9cbf9eb599f4dc5e305f5036:
>> 
>> trailers: do not quote names when special chars are present
>> 
>> When fixing potential email address rendering problems, we do not need
>> to be as stringent about the contents of the git trailer as when we are
>> dealing with actual email headers. For example, we do not need to quote
>> names containing things like commas or parentheses.
>> 
>> Reported-by: Matthew Wilcox <willy@infradead.org>
> 
> Surely that should be ...
> 
> Reported-by: Matthew Wilcox (Oracle) <willy@infradead.org>

Don't you mean:

Reported-by: "Matthew Wilcox (Oracle)" <willy@infradead.org>

/me hides

> 
> ;-)
> 
> Thanks for the quick fix!
> 

Re: "b4 am" quotes parens in S-o-b lines

[Konstantin Ryabitsev]

On Mon, Oct 16, 2023 at 08:37:39PM +0100, Matthew Wilcox wrote:
> Quick example:
> 
> $ b4 am 20231012195415.282357-1-willy@infradead.org
> $ grep Signed ./20231012_willy_allow_nesting_of_lazy_mmu_mode.mbx
> Signed-off-by: "Matthew Wilcox (Oracle)" <willy@infradead.org>
> Signed-off-by: "Matthew Wilcox (Oracle)" <willy@infradead.org>
> 
> The quote marks do not appear in the original emails, eg
> https://lore.kernel.org/all/20231012195415.282357-2-willy@infradead.org/
> 
> Adding the quotes around the name is not needed; I have many commits
> in Linux without the quote marks.

This should be fixed in master and stable-0.12.y. I will probably release
version 0.12.4 some time in the near future.

Thank you for the report.

-K