Re: [PATCH] netfs, ceph: Partially revert "netfs: Replace PG_fscache by setting folio->private and marking dirty"

Re: [PATCH] netfs, ceph: Partially revert "netfs: Replace PG_fscache by setting folio->private and marking dirty"

[Christian Brauner]

On Wed, Aug 14, 2024 at 08:50:03PM GMT, David Howells wrote:
>     
> This partially reverts commit 2ff1e97587f4d398686f52c07afde3faf3da4e5c.
> 
> In addition to reverting the removal of PG_private_2 wrangling from the
> buffered read code[1][2], the removal of the waits for PG_private_2 from
> netfs_release_folio() and netfs_invalidate_folio() need reverting too.
> 
> It also adds a wait into ceph_evict_inode() to wait for netfs read and
> copy-to-cache ops to complete.
> 
> Fixes: 2ff1e97587f4 ("netfs: Replace PG_fscache by setting folio->private and marking dirty")
> Signed-off-by: David Howells <dhowells@redhat.com>
> cc: Max Kellermann <max.kellermann@ionos.com>
> cc: Ilya Dryomov <idryomov@gmail.com>
> cc: Xiubo Li <xiubli@redhat.com>
> cc: Jeff Layton <jlayton@kernel.org>
> cc: Matthew Wilcox <willy@infradead.org>
> cc: ceph-devel@vger.kernel.org
> cc: netfs@lists.linux.dev
> cc: linux-fsdevel@vger.kernel.org
> cc: linux-mm@kvack.org
> Link: https://lore.kernel.org/r/3575457.1722355300@warthog.procyon.org.uk [1]
> Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8e5ced7804cb9184c4a23f8054551240562a8eda [2]
> ---

Now in vfs.fixes.

@Konstantin, for some reason I keep having issues with this patch
series. It confuses b4 to no end. When I try to shazam this single patch
here using 2181767.1723665003@warthog.procyon.org.uk it pull down a 26
patch series. And with -P _ it complains that it can't find the messag
id.

Re: [PATCH] netfs, ceph: Partially revert "netfs: Replace PG_fscache by setting folio->private and marking dirty"

[Konstantin Ryabitsev]

On Thu, Aug 15, 2024 at 02:51:58PM GMT, Christian Brauner wrote:
> @Konstantin, for some reason I keep having issues with this patch
> series. It confuses b4 to no end. When I try to shazam this single patch
> here using 2181767.1723665003@warthog.procyon.org.uk it pull down a 26
> patch series. And with -P _ it complains that it can't find the messag
> id.

I cannot reproduce this, which suggests to me that there's something going on
with cached data specific to your local content. Can you please run the
following:

    b4 -d shazam 2181767.1723665003@warthog.procyon.org.uk > /tmp/b4-debug.out 2>&1

then gzip and send that to me?

-K