[b4] CRITICAL: prep-pre-flight-checks must be a list, got str

[b4] CRITICAL: prep-pre-flight-checks must be a list, got str

[Nathan Chancellor]

After commit 8cae108 ("Further mypy typing enhancements"), I am seeing
an error when running 'b4 send':

  $ b4 send
  Converted the branch to 1 messages
  CRITICAL: prep-pre-flight-checks must be a list, got str

The following diff appears to resolve it for me.

Cheers,
Nathan

diff --git a/src/b4/ez.py b/src/b4/ez.py
index 0b24d50..df248bf 100644
--- a/src/b4/ez.py
+++ b/src/b4/ez.py
@@ -2005,7 +2005,7 @@ def cmd_send(cmdargs: argparse.Namespace) -> None:
                         'needs-checking-deps': True,
                         'needs-auto-to-cc': True,
                         }
-            cfg_checks = config.get('prep-pre-flight-checks', 'enable-all')
+            cfg_checks = config.get('prep-pre-flight-checks', ['enable-all'])
             if not isinstance(cfg_checks, list):
                 logger.critical('CRITICAL: prep-pre-flight-checks must be a list, got %s', type(cfg_checks).__name__)
                 sys.exit(1)

Re: [b4] CRITICAL: prep-pre-flight-checks must be a list, got str

[Konstantin Ryabitsev]

On Tue, Jun 10, 2025 at 12:46:24PM -0700, Nathan Chancellor wrote:
> After commit 8cae108 ("Further mypy typing enhancements"), I am seeing
> an error when running 'b4 send':
> 
>   $ b4 send
>   Converted the branch to 1 messages
>   CRITICAL: prep-pre-flight-checks must be a list, got str

Thank you for the report. I didn't take the patch, because the way this was
implemented needed to be redone anyway. Please check the latest master, and
thank you for trying out the bleeding edge!

-K