[PATCH] b4: Fix offline mbox --check case

[PATCH] b4: Fix offline mbox --check case

[David Nyström]

Without this patch:
--
b4 -d   shazam --check -s 20251028140009.2164260-1-archana.polampalli@windriver.com
    ● oe-checkpatch-dump.sh: Saved /tmp/b4-check-eenY4T.eml (6150 bytes)

b4 -d --offline-mode shazam --check -s -m openembedded-core.mbox \
  20251028140009.2164260-1-archana.polampalli@windriver.com
Unable to get payload from message <20251028140009.2164260-1-archana.polampalli@windriver.com>
    ● oe-checkpatch-dump.sh: Saved /tmp/b4-check-YcwtJ7.eml (0 bytes)

With this patch:
--
b4 -d   shazam --check -s 20251028140009.2164260-1-archana.polampalli@windriver.com
    ● oe-checkpatch-dump.sh: Saved /tmp/b4-check-eenY4T.eml (6150 bytes)

b4 -d --offline-mode shazam --check -s -m openembedded-core.mbox \
  20251028140009.2164260-1-archana.polampalli@windriver.com
    ● oe-checkpatch-dump.sh: Saved /tmp/b4-check-QzxXnn.eml (11806 bytes)

Signed-off-by: David Nyström <david.nystrom@est.tech>
---
 src/b4/__init__.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/b4/__init__.py b/src/b4/__init__.py
index 33fbc3f..29682ed 100644
--- a/src/b4/__init__.py
+++ b/src/b4/__init__.py
@@ -1992,8 +1992,9 @@ class LoreMessage:
         bdata += nl.encode()
         payload = msg.get_payload(decode=True)
         if not isinstance(payload, bytes):
-            logger.critical('Unable to get payload from message %s', msg.get('Message-Id'))
-            return b''
+            # Ensure per-patch checkers always receive usable input even if from a local mbox
+            body_text, _charset = LoreMessage.get_payload(msg, use_patch=True)
+            payload = body_text.encode('utf-8', errors='replace')
         for bline in payload.split(b'\n'):
             bdata += re.sub(rb'[\r\n]*$', b'', bline) + nl.encode()
         return bdata
-- 
2.48.1

Re: [PATCH] b4: Fix offline mbox --check case

[Konstantin Ryabitsev]

On Fri, 31 Oct 2025 10:08:40 +0100, David Nyström wrote:
> b4: Fix offline mbox --check case

Applied, thanks!

[1/1] b4: Fix offline mbox --check case
      commit: c5b9ed8d8209ca478459bbcc08d2beb07f1b2997

Best regards,
-- 
KR