b4 review not picking up v2 with prefix?

b4 review not picking up v2 with prefix?

[Lorenzo Stoakes]

Hi Konstantin,

Thanks for b4 review is a great tool that I'm now integrating into my workflow
(alongside b4 for sending series which I previously... resisted :)

So maybe an edge case here, and sorry for lazy report vs. patching (just so much
to do elsewhere) but for series [0] I set a mm-hotfixes prefix via:

$ b4 prep --set-prefixes 'mm-hotfixes'

Which is a convention in mm used sometimes to highlight that a series/patch
is a hotfix.

I have the v1 tracked ([1]), but when doing an update via 'u' or 'U' in the
review tui it doesn't seem to find the v2.

To make things more complicated, I sent patches separately previously ([2]
and [3]) which I decided to combine into the series sent in [0].

$ b4 --version
0.15.2

Thanks, Lorenzo

(And yes I am using b4 review to track my own series as well as reviews :P
makes it easier for me to keep track of what I've sent also :)

[0]:https://lore.kernel.org/linux-mm/20260712-series-vmap-race-fix-v2-0-ad134cc3a12a@kernel.org/
[1]:https://lore.kernel.org/all/20260710-series-vmap-race-fix-v1-0-5b3794c113fe@kernel.org/
[2]:https://lore.kernel.org/all/20260710-fix-cpa-ptdump-race-v1-1-d898699a7417@kernel.org/
[3]:https://lore.kernel.org/all/20260710-b4-fix-non-init_mm-ptdump-v1-1-2d40982c98ec@kernel.org/

Re: b4 review not picking up v2 with prefix?

[Lorenzo Stoakes (ARM)]

On Sun, Jul 12, 2026 at 12:06:49PM +0100, Lorenzo Stoakes wrote:
> Hi Konstantin,
>
> Thanks for b4 review is a great tool that I'm now integrating into my workflow
> (alongside b4 for sending series which I previously... resisted :)
>
> So maybe an edge case here, and sorry for lazy report vs. patching (just so much
> to do elsewhere) but for series [0] I set a mm-hotfixes prefix via:
>
> $ b4 prep --set-prefixes 'mm-hotfixes'
>
> Which is a convention in mm used sometimes to highlight that a series/patch
> is a hotfix.
>
> I have the v1 tracked ([1]), but when doing an update via 'u' or 'U' in the
> review tui it doesn't seem to find the v2.
>
> To make things more complicated, I sent patches separately previously ([2]
> and [3]) which I decided to combine into the series sent in [0].

Ohhh this may be on purpose. I noticed with v3 that it picked it up, but kept it
at v2, and prompted me to do 'a' (action) then 'U' (upgrade) so possibly PEBKAC
here :>)

>
> $ b4 --version
> 0.15.2
>
> Thanks, Lorenzo
>
> (And yes I am using b4 review to track my own series as well as reviews :P
> makes it easier for me to keep track of what I've sent also :)
>
> [0]:https://lore.kernel.org/linux-mm/20260712-series-vmap-race-fix-v2-0-ad134cc3a12a@kernel.org/
> [1]:https://lore.kernel.org/all/20260710-series-vmap-race-fix-v1-0-5b3794c113fe@kernel.org/
> [2]:https://lore.kernel.org/all/20260710-fix-cpa-ptdump-race-v1-1-d898699a7417@kernel.org/
> [3]:https://lore.kernel.org/all/20260710-b4-fix-non-init_mm-ptdump-v1-1-2d40982c98ec@kernel.org/

Cheers, Lorenzo

Re: b4 review not picking up v2 with prefix?

[Konstantin Ryabitsev]

On Wed, Jul 15, 2026 at 03:05:25PM +0100, Lorenzo Stoakes (ARM) wrote:
> > Thanks for b4 review is a great tool that I'm now integrating into my workflow
> > (alongside b4 for sending series which I previously... resisted :)
> >
> > So maybe an edge case here, and sorry for lazy report vs. patching (just so much
> > to do elsewhere) but for series [0] I set a mm-hotfixes prefix via:
> >
> > $ b4 prep --set-prefixes 'mm-hotfixes'
> >
> > Which is a convention in mm used sometimes to highlight that a series/patch
> > is a hotfix.
> >
> > I have the v1 tracked ([1]), but when doing an update via 'u' or 'U' in the
> > review tui it doesn't seem to find the v2.
> >
> > To make things more complicated, I sent patches separately previously ([2]
> > and [3]) which I decided to combine into the series sent in [0].
> 
> Ohhh this may be on purpose. I noticed with v3 that it picked it up, but kept it
> at v2, and prompted me to do 'a' (action) then 'U' (upgrade) so possibly PEBKAC
> here :>)

Yes, we want to avoid a rug-pull scenario where you're working on reviewing v1
and then a new version arrives. We just mark it as "upgrade available" and
then you can do things like range-diff the series before you upgrade, in case
you want to decide if you want to send your review for v1 at all, or start
fresh with v2.

I'll see if we can make this a bit more obvious, since the fact that you sent
a message about this tells me that it's currently doing something confusing.

-K