Linux maintainer tooling and workflows
 help / color / mirror / Atom feed
From: Mostafa Saleh <smostafa@google.com>
To: tools@kernel.org
Cc: Mostafa Saleh <smostafa@google.com>
Subject: [PATCH b4] b4: Ignore Signed-off-by trailers in follow-up replies
Date: Sat,  8 Aug 2026 16:47:08 +0000	[thread overview]
Message-ID: <20260808164708.1084648-1-smostafa@google.com> (raw)

When someone replies to a patch thread, sometimes they include a
Signed-off-by trailer (for example, when providing inline diffs or
snippets in a reply). Currently, b4 am/shazam collect these tags
from replies and append them to the main patch's trailers.

I am not aware of any use case when collecting the Signed-off-by
is needed, so drop it in this case.

Assisted-by: Gemini:gemini-3.1-pro-preview
Signed-off-by: Mostafa Saleh <smostafa@google.com>

---
I hit this when using:
b4 shazam -v1 https://lore.kernel.org/all/20260806150105.4010701-1-smostafa@google.com/

It collected the tag from Marc's patch in my patch as in:
https://lore.kernel.org/all/20260808085824.732659-4-smostafa@google.com/
Which is wrong.
---
 src/b4/__init__.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/b4/__init__.py b/src/b4/__init__.py
index a52b001..fd33111 100644
--- a/src/b4/__init__.py
+++ b/src/b4/__init__.py
@@ -1857,6 +1857,7 @@ class LoreMessage:
                     'base-commit',
                     'change-id',
                     'message-id',
+                    'signed-off-by',
                 }
                 if trailer.lname not in badtrailers:
                     trailer.lmsg = self
-- 
2.55.0.654.g21b8a5bc05-goog


             reply	other threads:[~2026-08-08 16:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-08 16:47 Mostafa Saleh [this message]
2026-08-17  7:14 ` [PATCH b4] b4: Ignore Signed-off-by trailers in follow-up replies Weijie Yuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260808164708.1084648-1-smostafa@google.com \
    --to=smostafa@google.com \
    --cc=tools@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox