[PATCH b4] b4: Ignore Signed-off-by trailers in follow-up replies

[PATCH b4] b4: Ignore Signed-off-by trailers in follow-up replies

[Mostafa Saleh]

When someone replies to a patch thread, sometimes they include a
Signed-off-by trailer (for example, when providing inline diffs or
snippets in a reply). Currently, b4 am/shazam collect these tags
from replies and append them to the main patch's trailers.

I am not aware of any use case when collecting the Signed-off-by
is needed, so drop it in this case.

Assisted-by: Gemini:gemini-3.1-pro-preview
Signed-off-by: Mostafa Saleh <smostafa@google.com>

---
I hit this when using:
b4 shazam -v1 https://lore.kernel.org/all/20260806150105.4010701-1-smostafa@google.com/

It collected the tag from Marc's patch in my patch as in:
https://lore.kernel.org/all/20260808085824.732659-4-smostafa@google.com/
Which is wrong.
---
 src/b4/__init__.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/b4/__init__.py b/src/b4/__init__.py
index a52b001..fd33111 100644
--- a/src/b4/__init__.py
+++ b/src/b4/__init__.py
@@ -1857,6 +1857,7 @@ class LoreMessage:
                     'base-commit',
                     'change-id',
                     'message-id',
+                    'signed-off-by',
                 }
                 if trailer.lname not in badtrailers:
                     trailer.lmsg = self
-- 
2.55.0.654.g21b8a5bc05-goog

Re: [PATCH b4] b4: Ignore Signed-off-by trailers in follow-up replies

[Weijie Yuan]

On Sat, Aug 08, 2026 at 04:47:08PM +0000, Mostafa Saleh wrote:
> When someone replies to a patch thread, sometimes they include a
> Signed-off-by trailer (for example, when providing inline diffs or
> snippets in a reply). Currently, b4 am/shazam collect these tags
> from replies and append them to the main patch's trailers.
> 
> I am not aware of any use case when collecting the Signed-off-by
> is needed, so drop it in this case.
> 
> Assisted-by: Gemini:gemini-3.1-pro-preview
> Signed-off-by: Mostafa Saleh <smostafa@google.com>
> 
> ---
> I hit this when using:
> b4 shazam -v1 https://lore.kernel.org/all/20260806150105.4010701-1-smostafa@google.com/
> 
> It collected the tag from Marc's patch in my patch as in:
> https://lore.kernel.org/all/20260808085824.732659-4-smostafa@google.com/
> Which is wrong.

I have a simailar case?

My reply [1] contains a standard template of a commit message for
Chinese translation patches with a sample Signed-off-by in it.

So when using 'b4 am/shazam', the sample Signed-off-by would be added as
one trailer. I was curious and spent some time to figure out where the
Sob exactly come from within that quite large series, since that sample
name/maintainer didn't show up in that conversation at all. ;-)

And I am also not aware of any use case when collecting the Signed-off-by
is needed, though I'm quite new in this community without much
experience.

Thanks,
Weijie

[1] https://lore.kernel.org/linux-doc/amDdPZ4SqBNg1kBa@wyuan.org/