* b4 review: please update the requirements files
@ 2026-06-30 9:28 Matthieu Baerts
2026-07-01 10:55 ` Matthieu Baerts
0 siblings, 1 reply; 2+ messages in thread
From: Matthieu Baerts @ 2026-06-30 9:28 UTC (permalink / raw)
To: Konstantin Ryabitsev; +Cc: Kernel.org Tools
Hi Konstantin,
Thank you for having updated b4 review!
Today, I tried to use 'b4 review tui', latest dev version -- 4217c3e
("plan: normalize body text to valid vim-outliner markup") -- but I got
a few crashes, e.g. the following one when using the 'Update all'
"button":
---------------------------- 8< ----------------------------
/src/b4/src/b4/review_tui/_modals.py:2781 in on_mount
2778 │ │ │ )
2779 │
2780 │ def on_mount(self) -> None:
❱ 2781 │ │ run_lore_worker(self, self._do_updates, name='_do_updates')
2782 │
2783 │ def action_cancel(self) -> None:
2784 │ │ self._cancelled = True
╭───────── locals ─────────╮
│ self = UpdateAllScreen() │
╰──────────────────────────╯
/src/b4/src/b4/review_tui/_common.py:266 in run_lore_worker
263 │ ``WorkerFailed`` (``exit_on_error=False``), so it surfaces through the
264 │ host's ``on_worker_state_changed`` handler instead.
265 │ """
❱ 266 │ with lore_request():
267 │ │ return host.run_worker(
268 │ │ │ work, name=name, thread=True, exit_on_error=exit_on_error, **kwargs
269 │ │ )
╭──────────────────────────────────── locals ─────────────────────────────────────╮
│ exit_on_error = False │
│ host = UpdateAllScreen() │
│ kwargs = {} │
│ name = '_do_updates' │
│ work = <bound method UpdateAllScreen._do_updates of UpdateAllScreen()> │
╰─────────────────────────────────────────────────────────────────────────────────╯
/usr/lib/python3.14/contextlib.py:141 in __enter__
138 │ │ # they are only needed for recreation, which is not possible anymore
139 │ │ del self.args, self.kwds, self.func
140 │ │ try:
❱ 141 │ │ │ return next(self.gen)
142 │ │ except StopIteration:
143 │ │ │ raise RuntimeError("generator didn't yield") from None
144
╭─────────────────────────────── locals ────────────────────────────────╮
│ self = <contextlib._GeneratorContextManager object at 0x7e55b9903230> │
╰───────────────────────────────────────────────────────────────────────╯
/src/b4/src/b4/review_tui/_common.py:238 in lore_request
235 │ left behind by a prior aborted operation. Use it directly around a
236 │ synchronous fetch, or via :func:`run_lore_worker` for a threaded one.
237 │ """
❱ 238 │ b4.get_lore_node().reset_cancel()
239 │ yield
240
241
AttributeError: 'LoreNode' object has no attribute 'reset_cancel'
---------------------------- 8< ----------------------------
Note that I also had a crash with the 'update' and 'review' "buttons".
I initially thought that it was because my tracked list contains patches
from the end of April, and that's why I first tried to "clean" my
environment by renaming ~/.cache/b4, ~/.local/share/b4 and ~/.local/
hare/b4-archived directory. But I still had patches in the list. I
finally fixed the issue by updating the requirements files, but first:
how do I reset b4 review?
When you have a chance, could you please update these requirements
files? I guess you prefer to apply the modifications generated by 'uv'
yourself.
(While at it, it might be good to have batch actions on the tracked list
view as well :) )
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: b4 review: please update the requirements files
2026-06-30 9:28 b4 review: please update the requirements files Matthieu Baerts
@ 2026-07-01 10:55 ` Matthieu Baerts
0 siblings, 0 replies; 2+ messages in thread
From: Matthieu Baerts @ 2026-07-01 10:55 UTC (permalink / raw)
To: Konstantin Ryabitsev; +Cc: Kernel.org Tools
On 30/06/2026 11:28, Matthieu Baerts wrote:
(...)
> I initially thought that it was because my tracked list contains patches
> from the end of April, and that's why I first tried to "clean" my
> environment by renaming ~/.cache/b4, ~/.local/share/b4 and ~/.local/
> hare/b4-archived directory. But I still had patches in the list. I
> finally fixed the issue by updating the requirements files, but first:
> how do I reset b4 review?
I think I found out why I still had items in the list: I guess I also
need to remove all the "b4/review/*" branches to fully reset b4 review.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-01 10:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-30 9:28 b4 review: please update the requirements files Matthieu Baerts
2026-07-01 10:55 ` Matthieu Baerts
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox