Re: b4 review tui: too smart reply features?

[Matthieu Baerts <matttbe@kernel.org>]

Hi Konstantin,

On 29/07/2026 06:38, Konstantin Ryabitsev wrote:
> On Tue, Jun 30, 2026 at 12:55:25PM +0200, Matthieu Baerts wrote:
>> I just retried, and it is indeed much better now! Yet, I still have an
>> issue with trailers, e.g.
>>
>>   Please add a Fixes tag. Here I guess it should be:
>>
>>   Fixes: (...)
>>
>> The Review view then correctly showed my comment with the Fixes tag, but
>> *I think* the Fixes tag was not visible in green at the bottom left (not
>> sure, because I also added a Reviewed-by tag after the reply). When
>> looking at the 'email mode' view, the Fixes tag got dropped, leaving 2
>> empty lines around.
> 
> This turned out to be two separate bugs, thanks for the detailed description!
> 
> There's an attempted fix in the current master: the trailer menu now only ever
> touches its own trailer types (Acked-by, Reviewed-by, Tested-by, NACKed-by).
> Anything else you type into the reply -- Fixes:, Cc:, Suggested-by:, whatever
> -- is treated as your content and is never moved or removed.
> 
> Removing a trailer via the menu should also no longer leave a doubled blank
> line behind.
> 
>> Back to the 'reply' view, vim showed all lines ending with ^M, and the line
>> starting with 'Fixes:' was no longer there. Adding it back re-added it to
>> the other views, and the Fixes tag was also listed at the bottom left in the
>> 'review' view, but I could see extra new lines due to all these \r.
>> Stripping them from the 'reply' view fixes all the issues, and I was able to
>> send the reply with both my Fixes and Reviewed-by tags.
>>
>> Any idea was caused that? :)
> 
> That was bug number two, also with a fix on mater: b4 now normalizes
> line endings on every editor round-trip, whatever your editor decides to
> write, and previously stored buffers get cleaned up the next time they're
> touched.
> 
> Try them out!

Thank you, I re-tried today (after I saw all boxes were checked for
v0.16), and it is smoother indeed!

BTW, thank you for the v0.16!

>> BTW, after having sent a reply, it appears a few seconds later as unread in
>> my inbox. I guess only a filter on the inbox side can help to mark them as
>> read, right?
> 
> This annoys me, too, so I'll think of a way to handle this.

If it could also mark the patch I'm replying too as read, that would be
even better! But I guess it is not planned to give IMAP access :)
I guess yet another filter on the mail side could help, but maybe
trickier (or simply "ignoring" all patches that are supposed to be
handled by b4 by moving them to a different folder).

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.