B4 thanks helper

B4 thanks helper

[Andrew Lunn]

Hi Konstantin

In your LPC talk you said you were working on having B4 generate Thank
You's for when a patchset is merged.

patchwork already has something like this. Here is one from the netdev
list. The problem with this is that it is anonymous. You have no idea
who did the merge. With netdev, there are two maintainers, and other
subsystems have multiple maintainers.

Maybe this is not an issue for b4, if it is used within the MTA, not a
bot. But it would be nice if the generated text contained the
maintainers name doing the merge.

      Andrew

----- Forwarded message from patchwork-bot+netdevbpf@kernel.org -----

Date: Mon, 20 Sep 2021 09:10:07 +0000
From: patchwork-bot+netdevbpf@kernel.org
To: Michael Chan <michael.chan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, kuba@kernel.org, gospo@broadcom.com
Subject: Re: [PATCH net] bnxt_en: Fix TX timeout when TX ring size is set to the smallest
X-Spam-Status: No, score=-6.4 required=4.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS
	autolearn=ham autolearn_force=no version=3.4.6

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Mon, 20 Sep 2021 02:51:52 -0400 you wrote:
> The smallest TX ring size we support must fit a TX SKB with MAX_SKB_FRAGS
> + 1.  Because the first TX BD for a packet is always a long TX BD, we
> need an extra TX BD to fit this packet.  Define BNXT_MIN_TX_DESC_CNT with
> this value to make this more clear.  The current code uses a minimum
> that is off by 1.  Fix it using this constant.
> 
> The tx_wake_thresh to determine when to wake up the TX queue is half the
> ring size but we must have at least BNXT_MIN_TX_DESC_CNT for the next
> packet which may have maximum fragments.  So the comparison of the
> available TX BDs with tx_wake_thresh should be >= instead of > in the
> current code.  Otherwise, at the smallest ring size, we will never wake
> up the TX queue and will cause TX timeout.
> 
> [...]

Here is the summary with links:
  - [net] bnxt_en: Fix TX timeout when TX ring size is set to the smallest
    https://git.kernel.org/netdev/net/c/5bed8b0704c9

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



----- End forwarded message -----

Re: B4 thanks helper

[Konstantin Ryabitsev]

On Mon, Sep 20, 2021 at 04:58:18PM +0200, Andrew Lunn wrote:
> Hi Konstantin
> 
> In your LPC talk you said you were working on having B4 generate Thank
> You's for when a patchset is merged.
> 
> patchwork already has something like this. Here is one from the netdev
> list. The problem with this is that it is anonymous. You have no idea
> who did the merge. With netdev, there are two maintainers, and other
> subsystems have multiple maintainers.

It's not really patchwork -- this is done by the git-patchwork-bot, a separate
(and older) tool that I wrote a while back:
https://korg.docs.kernel.org/patchwork/pwbot.html

> Maybe this is not an issue for b4, if it is used within the MTA, not a
> bot. But it would be nice if the generated text contained the
> maintainers name doing the merge.

I'll see if I can make the reports include the Author of the merge commit.
Thanks for the suggestion.

-K