b4 review tui: too smart reply features?

b4 review tui: too smart reply features?

[Matthieu Baerts]

Hi Konstantin,

I'm still trying 'b4 review tui', and something that bothers me is when
my replies are mangled. I have three examples.

- Most of the time, I don't send a reply with only a Reviewed-by tag,
but I add some text, e.g. "Thank you for the new version", "Good
catch!", "Please next time do this", "This should be that, but I will
fix it when applying it", etc. But then, when I look at the "email mode"
view, I don't know where the RvB tag will be added -- in dedicated email
apparently -- and the "trailers" menu doesn't show it checked any more.
Personally, when more text is added, I would prefer to send a single
email with the trailer tags placed where I want.

- When a tag is added in the "reply" view, it is no longer visible when
the "reply" view is re-opened. Also, in the "email mode" view, such tag
is displayed twice.

- Any word followed by a colon is interpreted as a tag and moved
elsewhere, e.g.

    <a long line ending with> you need to Cc
    stable: without that <rest of the line>
    <end>.

  Then in the "email mode" view, I can see:

    <a long line ending with> you need to Cc
    <end>.

    (...)

    stable: without that <rest of the line>

    stable: without that <rest of the line>

    --


Do you think the "reply" view could have an option to insert trailers
tags, and not move what has been added there? It feels simpler: if the
"reply" view is used, the text is not modified, but the code can still
be trimmed. If a tag has been previously added from the "trailers" menu,
it is added at the end of the commit message in the "reply" view, so
people can move it if needed.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.