From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Jarkko Sakkinen
<jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: "Martin Wilck"
<Martin.Wilck-RJz4owOZxyXQFUHtdCDX3A@public.gmane.org>,
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Uwe Kleine-König"
<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Subject: Re: [PATCH v3 7/7] tpm_crb: Use devm_ioremap_resource
Date: Mon, 4 Jan 2016 11:30:25 -0700 [thread overview]
Message-ID: <20160104183025.GE20016@obsidianresearch.com> (raw)
In-Reply-To: <20160103173213.GF4155-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Sun, Jan 03, 2016 at 07:32:13PM +0200, Jarkko Sakkinen wrote:
> On Thu, Dec 17, 2015 at 11:23:20AM -0700, Jason Gunthorpe wrote:
> > To support the force mode in tpm_tis we need to use resource locking
> > in tpm_crb as well, via devm_ioremap_resource.
> >
> > The light restructuring better aligns crb and tis and makes it easier
> > to see the that new changes make sense.
>
> This patch mixes two items: restructing and actual change.
Do you have a suggestion how to split this?
Everything is done for a reason, it isn't just churn for the sake of
churn.
Jason
------------------------------------------------------------------------------
next prev parent reply other threads:[~2016-01-04 18:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1450376600-6970-1-git-send-email-jgunthorpe@obsidianresearch.com>
[not found] ` <1450376600-6970-4-git-send-email-jgunthorpe@obsidianresearch.com>
[not found] ` <1450376600-6970-4-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-12-18 9:34 ` [PATCH v3 3/7] tpm_tis: Do not fall back to a hardcoded address for TPM2 Jarkko Sakkinen
2015-12-18 16:51 ` Jason Gunthorpe
[not found] ` <20151218165127.GC7354-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-12-20 12:34 ` Jarkko Sakkinen
[not found] ` <1450376600-6970-2-git-send-email-jgunthorpe@obsidianresearch.com>
[not found] ` <1450376600-6970-2-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-01-03 17:09 ` [PATCH v3 1/7] tpm_crb: Use the common ACPI definition of struct acpi_tpm2 Jarkko Sakkinen
[not found] ` <20160103170906.GA4155-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-01-04 18:23 ` Jason Gunthorpe
[not found] ` <20160104182317.GB20016-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-01-04 18:49 ` Jarkko Sakkinen
[not found] ` <1450376600-6970-3-git-send-email-jgunthorpe@obsidianresearch.com>
[not found] ` <1450376600-6970-3-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-01-03 17:20 ` [PATCH v3 2/7] tpm_tis: Disable interrupt auto probing on a per-device basis Jarkko Sakkinen
[not found] ` <20160103172040.GB4155-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-01-04 18:24 ` Jason Gunthorpe
[not found] ` <20160104182442.GC20016-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-01-04 18:32 ` Jarkko Sakkinen
[not found] ` <1450376600-6970-5-git-send-email-jgunthorpe@obsidianresearch.com>
[not found] ` <1450376600-6970-5-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-01-03 17:23 ` [PATCH v3 4/7] tpm_tis: Use devm_ioremap_resource Jarkko Sakkinen
[not found] ` <1450376600-6970-6-git-send-email-jgunthorpe@obsidianresearch.com>
2016-01-03 17:26 ` [PATCH v3 5/7] tpm_tis: Clean up the force=1 module parameter Jarkko Sakkinen
2016-01-04 18:27 ` Jason Gunthorpe
[not found] ` <1450376600-6970-7-git-send-email-jgunthorpe@obsidianresearch.com>
[not found] ` <1450376600-6970-7-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-01-03 17:28 ` [PATCH v3 6/7] tpm_crb: Drop le32_to_cpu(ioread32(..)) Jarkko Sakkinen
[not found] ` <1450376600-6970-8-git-send-email-jgunthorpe@obsidianresearch.com>
[not found] ` <1450376600-6970-8-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-01-03 17:32 ` [PATCH v3 7/7] tpm_crb: Use devm_ioremap_resource Jarkko Sakkinen
[not found] ` <20160103173213.GF4155-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-01-04 18:30 ` Jason Gunthorpe [this message]
2016-01-04 19:43 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160104183025.GE20016@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=Martin.Wilck-RJz4owOZxyXQFUHtdCDX3A@public.gmane.org \
--cc=jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox