Re: [PATCH 07/14] power: domain: meson-ee-pwrc: Staticize and constify driver ops

Re: [PATCH 07/14] power: domain: meson-ee-pwrc: Staticize and constify driver ops

[Peng Fan]

On Fri, May 08, 2026 at 02:22:07PM +0200, Marek Vasut wrote:
>Set the ops structure as static const. The structure is not accessible
>from outside of this driver and is not going to be modified at runtime.
>
>Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

Re: [PATCH 07/14] power: domain: meson-ee-pwrc: Staticize and constify driver ops

[Neil Armstrong]

On 5/8/26 14:22, Marek Vasut wrote:
> Set the ops structure as static const. The structure is not accessible
> from outside of this driver and is not going to be modified at runtime.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> ---
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: u-boot-amlogic@groups.io
> Cc: u-boot@lists.denx.de
> ---
>   drivers/power/domain/meson-ee-pwrc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/domain/meson-ee-pwrc.c b/drivers/power/domain/meson-ee-pwrc.c
> index 4d9f3bba644..6361f3a6c59 100644
> --- a/drivers/power/domain/meson-ee-pwrc.c
> +++ b/drivers/power/domain/meson-ee-pwrc.c
> @@ -386,7 +386,7 @@ static int meson_ee_pwrc_of_xlate(struct power_domain *power_domain,
>   	return 0;
>   }
>   
> -struct power_domain_ops meson_ee_pwrc_ops = {
> +static const struct power_domain_ops meson_ee_pwrc_ops = {
>   	.off = meson_ee_pwrc_off,
>   	.on = meson_ee_pwrc_on,
>   	.of_xlate = meson_ee_pwrc_of_xlate,

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil

Re: [PATCH 09/14] power: domain: meson-secure-pwrc: Staticize and constify driver ops

[Peng Fan]

On Fri, May 08, 2026 at 02:22:09PM +0200, Marek Vasut wrote:
>Set the ops structure as static const. The structure is not accessible
>from outside of this driver and is not going to be modified at runtime.
>
>Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

Re: [PATCH 08/14] power: domain: meson-gx-pwrc: Staticize and constify driver ops

[Peng Fan]

On Fri, May 08, 2026 at 02:22:08PM +0200, Marek Vasut wrote:
>Set the ops structure as static const. The structure is not accessible
>from outside of this driver and is not going to be modified at runtime.
>
>Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

Re: [PATCH 08/14] power: domain: meson-gx-pwrc: Staticize and constify driver ops

[Neil Armstrong]

On 5/8/26 14:22, Marek Vasut wrote:
> Set the ops structure as static const. The structure is not accessible
> from outside of this driver and is not going to be modified at runtime.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> ---
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: u-boot-amlogic@groups.io
> Cc: u-boot@lists.denx.de
> ---
>   drivers/power/domain/meson-gx-pwrc-vpu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/domain/meson-gx-pwrc-vpu.c b/drivers/power/domain/meson-gx-pwrc-vpu.c
> index 1c56e8508c3..325296b0dd7 100644
> --- a/drivers/power/domain/meson-gx-pwrc-vpu.c
> +++ b/drivers/power/domain/meson-gx-pwrc-vpu.c
> @@ -262,7 +262,7 @@ static int meson_pwrc_vpu_of_xlate(struct power_domain *power_domain,
>   	return 0;
>   }
>   
> -struct power_domain_ops meson_gx_pwrc_vpu_ops = {
> +static const struct power_domain_ops meson_gx_pwrc_vpu_ops = {
>   	.off = meson_pwrc_vpu_off,
>   	.on = meson_pwrc_vpu_on,
>   	.of_xlate = meson_pwrc_vpu_of_xlate,

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil