From: Sangmoon Kim <dogoil@etinsys.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [Patch] KVME080 Support
Date: Fri, 19 Aug 2005 12:22:58 +0900 [thread overview]
Message-ID: <005001c5a46d$4fb80e20$212d4cdc@smkim> (raw)
In-Reply-To: 20050818204152.36097353CE9@atlas.denx.de
Hi,
>
> Can you please split your patch into two?
>
I splited the patch and extracted KVME080 parts only.
>
> And please cleanup your code before re-submitting:
>
> * It violates the coding style requirements (trailing white space).
>
Sorry, I was suprised that my code had so many white spaces.
I am sure I fixed all of it now.
> * Using globally visible preprocessor defines like FLASH_WRITE64 is
> not acceptable (you also forgot to document these, but that would
> help either), and defining such code in the board config file is
> the wrong way to implement it either. The board config file is -
> ummm, a _configuration_ file, but does not contain source code.
>
I deleted the 'source code' from the board configuration file.
The current version of KVME080 board runs well without patching cfi_flash.c
I'll find an alternative way and send the patch for cfi_flash.c later.
>
> Also: please read the recent "U-Boot Developer's Information"
> posting; you are supposed to provide a "sign-off" line for all
> patches.
>
I added the "sign-off" line at the end of the patch.
Regards,
Sangmoon Kim
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kvme080.patch.gz
Type: application/x-gzip
Size: 7760 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20050819/50c86749/attachment.bin
next prev parent reply other threads:[~2005-08-19 3:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-18 9:57 [U-Boot-Users] [Patch] KVME080 Support Sangmoon Kim
2005-08-18 20:41 ` Wolfgang Denk
2005-08-19 3:22 ` Sangmoon Kim [this message]
2006-07-22 18:56 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005001c5a46d$4fb80e20$212d4cdc@smkim' \
--to=dogoil@etinsys.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox