[PATCH] s5p4418_nanopi2: Stop disabling device tree relocation

[PATCH] s5p4418_nanopi2: Stop disabling device tree relocation

[Tom Rini]

Remove setting of fdt_high to ~0, which disables device tree relocation,
from the default environment. Doing so prevents U-Boot from correcting
problems such as having an unaligned device tree and leads to various
failure modes in the OS.

Signed-off-by: Tom Rini <trini@konsulko.com>
---
If there is some window of memory that must be used for where the device
tree is relocated to, bootm_low + bootm_size (or often just bootm_size)
or bootm_mapsize are the correct way do this. Please see
doc/usage/environment.rst for more details.

Cc: Stefan Bosch <stefan_b@posteo.net>
---
 include/configs/s5p4418_nanopi2.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/configs/s5p4418_nanopi2.h b/include/configs/s5p4418_nanopi2.h
index fec1bfd50eb9..8a8d54daf7b4 100644
--- a/include/configs/s5p4418_nanopi2.h
+++ b/include/configs/s5p4418_nanopi2.h
@@ -139,7 +139,6 @@
 #endif
 
 #define CFG_EXTRA_ENV_SETTINGS				\
-	"fdt_high=0xffffffff\0"					\
 	"initrd_high=0xffffffff\0"				\
 	"rootdev=" __stringify(CONFIG_ROOT_DEV) "\0"		\
 	"rootpart=" __stringify(CONFIG_ROOT_PART) "\0"		\
-- 
2.43.0

Re: [PATCH] s5p4418_nanopi2: Stop disabling device tree relocation

[Stefan Bosch]

Hi Tom,

On 19.11.25 15:55, Tom Rini wrote:
> Remove setting of fdt_high to ~0, which disables device tree relocation,
> from the default environment. Doing so prevents U-Boot from correcting
> problems such as having an unaligned device tree and leads to various
> failure modes in the OS.
> 
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---

Tested-by: Stefan Bosch <stefan_b@posteo.net>

Looks OK, tested on FriendlyElec-Board NanoPC-T2 
(s5p4418_nanopi2_defconfig) with booting of LUbuntu Xenial (kernel 
4.4.49-s5p4418).

Thanks!

> If there is some window of memory that must be used for where the device
> tree is relocated to, bootm_low + bootm_size (or often just bootm_size)
> or bootm_mapsize are the correct way do this. Please see
> doc/usage/environment.rst for more details.
> 
> Cc: Stefan Bosch <stefan_b@posteo.net>
> ---
>   include/configs/s5p4418_nanopi2.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/include/configs/s5p4418_nanopi2.h b/include/configs/s5p4418_nanopi2.h
> index fec1bfd50eb9..8a8d54daf7b4 100644
> --- a/include/configs/s5p4418_nanopi2.h
> +++ b/include/configs/s5p4418_nanopi2.h
> @@ -139,7 +139,6 @@
>   #endif
>   
>   #define CFG_EXTRA_ENV_SETTINGS				\
> -	"fdt_high=0xffffffff\0"					\
>   	"initrd_high=0xffffffff\0"				\
>   	"rootdev=" __stringify(CONFIG_ROOT_DEV) "\0"		\
>   	"rootpart=" __stringify(CONFIG_ROOT_PART) "\0"		\

Regards,
Stefan

RE: [PATCH] s5p4418_nanopi2: Stop disabling device tree relocation

[Minkyu Kang]

Hi,

> If there is some window of memory that must be used for where the 
> device tree is relocated to, bootm_low + bootm_size (or often just 
> bootm_size) or bootm_mapsize are the correct way do this. Please see 
> doc/usage/environment.rst for more details.
> 
> Cc: Stefan Bosch <stefan_b@posteo.net>
> ---
>   include/configs/s5p4418_nanopi2.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/include/configs/s5p4418_nanopi2.h 
> b/include/configs/s5p4418_nanopi2.h
> index fec1bfd50eb9..8a8d54daf7b4 100644
> --- a/include/configs/s5p4418_nanopi2.h
> +++ b/include/configs/s5p4418_nanopi2.h
> @@ -139,7 +139,6 @@
>   #endif
>   
>   #define CFG_EXTRA_ENV_SETTINGS				\
> -	"fdt_high=0xffffffff\0"					\
>   	"initrd_high=0xffffffff\0"				\
>   	"rootdev=" __stringify(CONFIG_ROOT_DEV) "\0"		\
>   	"rootpart=" __stringify(CONFIG_ROOT_PART) "\0"		\

Applied to u-boot-samsung.

Thanks,
Minkyu Kang.