From: Ovidiu Panait <ovpanait@gmail.com>
To: Simon Glass <sjg@chromium.org>
Cc: u-boot@lists.denx.de, Andy Shevchenko <andy.shevchenko@gmail.com>,
Patrice Chotard <patrice.chotard@foss.st.com>
Subject: Re: [PATCH 2/3] timer-uclass: relocate ops pointers for CONFIG_NEEDS_MANUAL_RELOC
Date: Wed, 12 Oct 2022 18:21:15 +0300 [thread overview]
Message-ID: <032f6631-fd52-a0ec-03d8-d56d45875bd0@gmail.com> (raw)
In-Reply-To: <CAPnjgZ3mUG2xtKPfoZNpBBrXfk1F3KfgSU6qgQ_s70ZbqzuQXw@mail.gmail.com>
Hi Simon,
On 10/12/22 15:59, Simon Glass wrote:
> On Tue, 11 Oct 2022 at 23:37, Ovidiu Panait <ovpanait@gmail.com> wrote:
>> Relocate timer_ops pointers when CONFIG_NEEDS_MANUAL_RELOC is enabled.
>>
>> The (gd->flags & GD_FLG_RELOC) check was added to make sure the reloc_done
>> logic works for drivers that use DM_FLAG_PRE_RELOC.
>>
>> Signed-off-by: Ovidiu Panait <ovpanait@gmail.com>
>> ---
>>
>> drivers/timer/timer-uclass.c | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> Which (broken) toolchain are you using?
Microblaze and m68k still use CONFIG_NEEDS_MANUAL_RELOC=y by default. I
was testing on microblaze.
Ovidiu
next prev parent reply other threads:[~2022-10-12 15:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 5:36 [PATCH 1/3] timer-uclass: add timer_get_ops() macro Ovidiu Panait
2022-10-12 5:36 ` [PATCH 2/3] timer-uclass: relocate ops pointers for CONFIG_NEEDS_MANUAL_RELOC Ovidiu Panait
2022-10-12 12:59 ` Simon Glass
2022-10-12 15:21 ` Ovidiu Panait [this message]
2022-10-12 5:36 ` [PATCH 3/3] timer: xilinx-timer: use timer_conv_64() to fix timer wrap around Ovidiu Panait
2022-10-12 8:58 ` Michal Simek
2022-10-25 9:32 ` Michal Simek
2022-10-12 12:59 ` [PATCH 1/3] timer-uclass: add timer_get_ops() macro Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=032f6631-fd52-a0ec-03d8-d56d45875bd0@gmail.com \
--to=ovpanait@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=patrice.chotard@foss.st.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox