U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Teresa Remmet <T.Remmet@phytec.de>
To: "trini@konsulko.com" <trini@konsulko.com>,
	"u-boot@lists.denx.de" <u-boot@lists.denx.de>
Subject: Re: [PATCH] phycore_imx8mp: Rework some of the RAM related Kconfig symbols
Date: Mon, 17 Mar 2025 07:29:12 +0000	[thread overview]
Message-ID: <03559683db3004621f7b68f0f89c64a4e0719fba.camel@phytec.de> (raw)
In-Reply-To: <20250315012916.399442-1-trini@konsulko.com>

Am Freitag, dem 14.03.2025 um 19:29 -0600 schrieb Tom Rini:
> As the code is today, we get a warning about "select" statements on
> "choice" options not doing anything. In this case we can easily fix
> this
> by dropping the select line as the following choice statement handles
> things correctly. We also drop the "default false" line as false / n
> is
> the default.
> 
> Signed-off-by: Tom Rini <trini@konsulko.com>

Reviewed-by: Teresa Remmet <t.remmet@phytec.de>

> ---
> Cc: Teresa Remmet <t.remmet@phytec.de>
> ---
>  board/phytec/phycore_imx8mp/Kconfig | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/board/phytec/phycore_imx8mp/Kconfig
> b/board/phytec/phycore_imx8mp/Kconfig
> index bdf9e97beaa6..caf9cb0c3c39 100644
> --- a/board/phytec/phycore_imx8mp/Kconfig
> +++ b/board/phytec/phycore_imx8mp/Kconfig
> @@ -45,7 +45,6 @@ config PHYCORE_IMX8MP_RAM_SIZE_4GB
>  
>  config PHYCORE_IMX8MP_RAM_SIZE_8GB
>         bool "8GB RAM"
> -       select PHYCORE_IMX8MP_USE_2GHZ_RAM_TIMINGS
>         help
>           Set RAM size fix to 8GB for phyCORE-i.MX8MP.
>           Only 2GHz RAMs are supported.
> @@ -54,7 +53,6 @@ endchoice
>  
>  config PHYCORE_IMX8MP_RAM_FREQ_FIX
>         bool "Set phyCORE-i.MX8MP RAM frequency fix instead of
> detecting"
> -       default false
>         help
>           RAM frequency is automatic being detected with the help of
>           the EEPROM introspection data. Set RAM frequency to a fix
> value

-- 
PHYTEC Messtechnik GmbH | Barcelona-Allee 1 | 55129 Mainz, Germany

Geschäftsführer: Dipl.-Ing. Michael Mitezki, Dipl.-Ing. Bodo Huber,
Dipl.-Ing. (FH) Markus Lickes | Handelsregister Mainz HRB 4656 |
Finanzamt Mainz | St.Nr. 26/665/00608, DE 149059855

  reply	other threads:[~2025-03-17  7:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-15  1:29 [PATCH] phycore_imx8mp: Rework some of the RAM related Kconfig symbols Tom Rini
2025-03-17  7:29 ` Teresa Remmet [this message]
2025-03-21 12:32 ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=03559683db3004621f7b68f0f89c64a4e0719fba.camel@phytec.de \
    --to=t.remmet@phytec.de \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox