[PATCH] phycore_imx8mp: Rework some of the RAM related Kconfig symbols

[PATCH] phycore_imx8mp: Rework some of the RAM related Kconfig symbols

[Tom Rini]

As the code is today, we get a warning about "select" statements on
"choice" options not doing anything. In this case we can easily fix this
by dropping the select line as the following choice statement handles
things correctly. We also drop the "default false" line as false / n is
the default.

Signed-off-by: Tom Rini <trini@konsulko.com>
---
Cc: Teresa Remmet <t.remmet@phytec.de>
---
 board/phytec/phycore_imx8mp/Kconfig | 2 --
 1 file changed, 2 deletions(-)

diff --git a/board/phytec/phycore_imx8mp/Kconfig b/board/phytec/phycore_imx8mp/Kconfig
index bdf9e97beaa6..caf9cb0c3c39 100644
--- a/board/phytec/phycore_imx8mp/Kconfig
+++ b/board/phytec/phycore_imx8mp/Kconfig
@@ -45,7 +45,6 @@ config PHYCORE_IMX8MP_RAM_SIZE_4GB
 
 config PHYCORE_IMX8MP_RAM_SIZE_8GB
 	bool "8GB RAM"
-	select PHYCORE_IMX8MP_USE_2GHZ_RAM_TIMINGS
 	help
 	  Set RAM size fix to 8GB for phyCORE-i.MX8MP.
 	  Only 2GHz RAMs are supported.
@@ -54,7 +53,6 @@ endchoice
 
 config PHYCORE_IMX8MP_RAM_FREQ_FIX
 	bool "Set phyCORE-i.MX8MP RAM frequency fix instead of detecting"
-	default false
 	help
 	  RAM frequency is automatic being detected with the help of
 	  the EEPROM introspection data. Set RAM frequency to a fix value
-- 
2.43.0

Re: [PATCH] phycore_imx8mp: Rework some of the RAM related Kconfig symbols

[Teresa Remmet]

Am Freitag, dem 14.03.2025 um 19:29 -0600 schrieb Tom Rini:
> As the code is today, we get a warning about "select" statements on
> "choice" options not doing anything. In this case we can easily fix
> this
> by dropping the select line as the following choice statement handles
> things correctly. We also drop the "default false" line as false / n
> is
> the default.
> 
> Signed-off-by: Tom Rini <trini@konsulko.com>

Reviewed-by: Teresa Remmet <t.remmet@phytec.de>

> ---
> Cc: Teresa Remmet <t.remmet@phytec.de>
> ---
>  board/phytec/phycore_imx8mp/Kconfig | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/board/phytec/phycore_imx8mp/Kconfig
> b/board/phytec/phycore_imx8mp/Kconfig
> index bdf9e97beaa6..caf9cb0c3c39 100644
> --- a/board/phytec/phycore_imx8mp/Kconfig
> +++ b/board/phytec/phycore_imx8mp/Kconfig
> @@ -45,7 +45,6 @@ config PHYCORE_IMX8MP_RAM_SIZE_4GB
>  
>  config PHYCORE_IMX8MP_RAM_SIZE_8GB
>         bool "8GB RAM"
> -       select PHYCORE_IMX8MP_USE_2GHZ_RAM_TIMINGS
>         help
>           Set RAM size fix to 8GB for phyCORE-i.MX8MP.
>           Only 2GHz RAMs are supported.
> @@ -54,7 +53,6 @@ endchoice
>  
>  config PHYCORE_IMX8MP_RAM_FREQ_FIX
>         bool "Set phyCORE-i.MX8MP RAM frequency fix instead of
> detecting"
> -       default false
>         help
>           RAM frequency is automatic being detected with the help of
>           the EEPROM introspection data. Set RAM frequency to a fix
> value

-- 
PHYTEC Messtechnik GmbH | Barcelona-Allee 1 | 55129 Mainz, Germany

Geschäftsführer: Dipl.-Ing. Michael Mitezki, Dipl.-Ing. Bodo Huber,
Dipl.-Ing. (FH) Markus Lickes | Handelsregister Mainz HRB 4656 |
Finanzamt Mainz | St.Nr. 26/665/00608, DE 149059855

Re: [PATCH] phycore_imx8mp: Rework some of the RAM related Kconfig symbols

[Fabio Estevam]

On Fri, Mar 14, 2025 at 10:30 PM Tom Rini <trini@konsulko.com> wrote:
>
> As the code is today, we get a warning about "select" statements on
> "choice" options not doing anything. In this case we can easily fix this
> by dropping the select line as the following choice statement handles
> things correctly. We also drop the "default false" line as false / n is
> the default.
>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> Cc: Teresa Remmet <t.remmet@phytec.de>

Applied to u-boot-imx/next, thanks.