From: Wadim Egorov <w.egorov@phytec.de>
To: Jonathan Humphreys <j-humphreys@ti.com>,
Raymond Mao <raymond.mao@linaro.org>,
Caleb Connolly <caleb.connolly@linaro.org>,
Adriano Cordova <adrianox@gmail.com>,
Michal Simek <michal.simek@amd.com>, Udit Kumar <u-kumar1@ti.com>,
Simon Glass <sjg@chromium.org>, Devarsh Thakkar <devarsht@ti.com>,
Hari Nagalla <hnagalla@ti.com>,
Manorit Chawdhry <m-chawdhry@ti.com>,
Santhosh Kumar K <s-k6@ti.com>,
Neha Malcom Francis <n-francis@ti.com>,
Daniel Schultz <d.schultz@phytec.de>,
Neil Armstrong <neil.armstrong@linaro.org>,
Aashvij Shenai <a-shenai@ti.com>,
Roger Quadros <rogerq@kernel.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Bryan Brattlof <bb@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Tom Rini <trini@konsulko.com>,
Robert Nelson <robertcnelson@gmail.com>,
Nishanth Menon <nm@ti.com>,
Sughosh Ganu <sughosh.ganu@linaro.org>,
Mattijs Korpershoek <mkorpershoek@baylibre.com>,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
Lukasz Majewski <lukma@denx.de>,
s-vadapalli@ti.com
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH v4 3/3] board: remove capsule update support in set_dfu_alt_info()
Date: Thu, 27 Feb 2025 12:07:58 +0700 [thread overview]
Message-ID: <08b7d14c-1535-46ea-9970-26ad2688e2f2@phytec.de> (raw)
In-Reply-To: <20250226223547.393611-4-j-humphreys@ti.com>
Am 27.02.25 um 05:35 schrieb Jonathan Humphreys:
> Now that capsule update sets the dfu_alt_info environment variable
> explicitly, there is no need to support it in the set_dfu_alt_info()
> function. Decouple SET_DFU_ALT_INFO from EFI_CAPSULE_FIRMWARE_FIT and
> EFI_CAPSULE_FIRMWARE_RAW. For many boards, this was the only use of
> set_dfu_alt_info() so remove the function entirely.
>
> Fixes: a9e6f01a941f ("efi: Define set_dfu_alt_info() for boards with UEFI capsule update enabled")
>
> Signed-off-by: Jonathan Humphreys <j-humphreys@ti.com>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> # for board/libre-computer/*
> Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> ---
> board/beagle/beagleboneai64/beagleboneai64.c | 8 --------
> board/beagle/beagleplay/beagleplay.c | 8 --------
> board/libre-computer/aml-a311d-cc/aml-a311d-cc.c | 2 --
> board/libre-computer/aml-s805x-ac/aml-s805x-ac.c | 2 --
> board/libre-computer/aml-s905d3-cc/aml-s905d3-cc.c | 2 --
> board/phytec/common/k3/board.c | 8 --------
> board/ti/am62px/evm.c | 8 --------
> board/ti/am62x/evm.c | 8 --------
> board/ti/am64x/evm.c | 8 --------
> board/ti/j721e/evm.c | 8 --------
> board/ti/j784s4/evm.c | 8 --------
> board/xilinx/common/board.h | 3 +++
> board/xilinx/versal/board.c | 13 ++++---------
> board/xilinx/zynq/board.c | 13 ++++---------
> board/xilinx/zynqmp/zynqmp.c | 13 ++++---------
> lib/efi_loader/Kconfig | 2 --
> lib/efi_loader/efi_firmware.c | 5 -----
> 17 files changed, 15 insertions(+), 104 deletions(-)
>
> diff --git a/board/beagle/beagleboneai64/beagleboneai64.c b/board/beagle/beagleboneai64/beagleboneai64.c
> index e8d07f1f95f..99eb8972cf3 100644
> --- a/board/beagle/beagleboneai64/beagleboneai64.c
> +++ b/board/beagle/beagleboneai64/beagleboneai64.c
> @@ -45,14 +45,6 @@ struct efi_capsule_update_info update_info = {
> .images = fw_images,
> };
>
> -#if IS_ENABLED(CONFIG_SET_DFU_ALT_INFO)
> -void set_dfu_alt_info(char *interface, char *devstr)
> -{
> - if (IS_ENABLED(CONFIG_EFI_HAVE_CAPSULE_SUPPORT))
> - env_set("dfu_alt_info", update_info.dfu_string);
> -}
> -#endif
> -
> int board_init(void)
> {
> return 0;
> diff --git a/board/beagle/beagleplay/beagleplay.c b/board/beagle/beagleplay/beagleplay.c
> index fae69b37585..78635810585 100644
> --- a/board/beagle/beagleplay/beagleplay.c
> +++ b/board/beagle/beagleplay/beagleplay.c
> @@ -41,14 +41,6 @@ struct efi_capsule_update_info update_info = {
> .images = fw_images,
> };
>
> -#if IS_ENABLED(CONFIG_SET_DFU_ALT_INFO)
> -void set_dfu_alt_info(char *interface, char *devstr)
> -{
> - if (IS_ENABLED(CONFIG_EFI_HAVE_CAPSULE_SUPPORT))
> - env_set("dfu_alt_info", update_info.dfu_string);
> -}
> -#endif
> -
> int board_init(void)
> {
> return 0;
> diff --git a/board/libre-computer/aml-a311d-cc/aml-a311d-cc.c b/board/libre-computer/aml-a311d-cc/aml-a311d-cc.c
> index e45cfd5d8a3..24363d21ab0 100644
> --- a/board/libre-computer/aml-a311d-cc/aml-a311d-cc.c
> +++ b/board/libre-computer/aml-a311d-cc/aml-a311d-cc.c
> @@ -31,8 +31,6 @@ void set_dfu_alt_info(char *interface, char *devstr)
> {
> if (strcmp(interface, "ram") == 0)
> env_set("dfu_alt_info", "fitimage ram 0x08080000 0x4000000");
> - else if (IS_ENABLED(CONFIG_EFI_HAVE_CAPSULE_SUPPORT))
> - env_set("dfu_alt_info", update_info.dfu_string);
> }
> #endif
>
> diff --git a/board/libre-computer/aml-s805x-ac/aml-s805x-ac.c b/board/libre-computer/aml-s805x-ac/aml-s805x-ac.c
> index 94cf5b4361f..42442f26acc 100644
> --- a/board/libre-computer/aml-s805x-ac/aml-s805x-ac.c
> +++ b/board/libre-computer/aml-s805x-ac/aml-s805x-ac.c
> @@ -38,8 +38,6 @@ void set_dfu_alt_info(char *interface, char *devstr)
> {
> if (strcmp(interface, "ram") == 0)
> env_set("dfu_alt_info", "fitimage ram 0x08080000 0x4000000");
> - else if (IS_ENABLED(CONFIG_EFI_HAVE_CAPSULE_SUPPORT))
> - env_set("dfu_alt_info", update_info.dfu_string);
> }
> #endif
>
> diff --git a/board/libre-computer/aml-s905d3-cc/aml-s905d3-cc.c b/board/libre-computer/aml-s905d3-cc/aml-s905d3-cc.c
> index f641db5a494..5223f1c8ab8 100644
> --- a/board/libre-computer/aml-s905d3-cc/aml-s905d3-cc.c
> +++ b/board/libre-computer/aml-s905d3-cc/aml-s905d3-cc.c
> @@ -31,8 +31,6 @@ void set_dfu_alt_info(char *interface, char *devstr)
> {
> if (strcmp(interface, "ram") == 0)
> env_set("dfu_alt_info", "fitimage ram 0x08080000 0x4000000");
> - else if (IS_ENABLED(CONFIG_EFI_HAVE_CAPSULE_SUPPORT))
> - env_set("dfu_alt_info", update_info.dfu_string);
> }
> #endif
>
> diff --git a/board/phytec/common/k3/board.c b/board/phytec/common/k3/board.c
> index 9d833456810..58859f279f1 100644
> --- a/board/phytec/common/k3/board.c
> +++ b/board/phytec/common/k3/board.c
> @@ -82,14 +82,6 @@ void configure_capsule_updates(void)
> }
> #endif
>
> -#if IS_ENABLED(CONFIG_SET_DFU_ALT_INFO)
> -void set_dfu_alt_info(char *interface, char *devstr)
> -{
> - if (IS_ENABLED(CONFIG_EFI_HAVE_CAPSULE_SUPPORT))
> - env_set("dfu_alt_info", update_info.dfu_string);
> -}
> -#endif
> -
> #if IS_ENABLED(CONFIG_ENV_IS_IN_FAT) || IS_ENABLED(CONFIG_ENV_IS_IN_MMC)
> int mmc_get_env_dev(void)
> {
Reviewed-by: Wadim Egorov <w.egorov@phytec.de> # for
board/phytec/common/k3/board.c
next prev parent reply other threads:[~2025-02-27 5:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 22:35 [PATCH v4 0/3] EFI Capsule update explicitly sets dfu_alt_info Jonathan Humphreys
2025-02-26 22:35 ` [PATCH v4 1/3] xilinx: dfu: Fill directly update_info.dfu_string Jonathan Humphreys
2025-02-28 14:33 ` Heinrich Schuchardt
2025-02-28 15:41 ` Michal Simek
2025-02-28 15:46 ` Heinrich Schuchardt
2025-02-28 18:15 ` Jon Humphreys
2025-03-03 14:02 ` Michal Simek
2025-02-26 22:35 ` [PATCH v4 2/3] efi_firmware: set EFI capsule dfu_alt_info env explicitly Jonathan Humphreys
2025-03-12 6:40 ` Ilias Apalodimas
2025-02-26 22:35 ` [PATCH v4 3/3] board: remove capsule update support in set_dfu_alt_info() Jonathan Humphreys
2025-02-27 5:07 ` Wadim Egorov [this message]
2025-04-09 14:52 ` [PATCH v4 0/3] EFI Capsule update explicitly sets dfu_alt_info Michal Simek
2025-04-09 21:36 ` Jon Humphreys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08b7d14c-1535-46ea-9970-26ad2688e2f2@phytec.de \
--to=w.egorov@phytec.de \
--cc=a-shenai@ti.com \
--cc=adrianox@gmail.com \
--cc=bb@ti.com \
--cc=caleb.connolly@linaro.org \
--cc=d.schultz@phytec.de \
--cc=devarsht@ti.com \
--cc=hnagalla@ti.com \
--cc=ilias.apalodimas@linaro.org \
--cc=j-humphreys@ti.com \
--cc=lukma@denx.de \
--cc=m-chawdhry@ti.com \
--cc=michal.simek@amd.com \
--cc=mkorpershoek@baylibre.com \
--cc=n-francis@ti.com \
--cc=neil.armstrong@linaro.org \
--cc=nm@ti.com \
--cc=rasmus.villemoes@prevas.dk \
--cc=raymond.mao@linaro.org \
--cc=robertcnelson@gmail.com \
--cc=rogerq@kernel.org \
--cc=s-k6@ti.com \
--cc=s-vadapalli@ti.com \
--cc=sjg@chromium.org \
--cc=sughosh.ganu@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox