Re: [PATCH v4 1/3] xilinx: dfu: Fill directly update_info.dfu_string

[Jon Humphreys <j-humphreys@ti.com>]

Heinrich Schuchardt <xypron.glpk@gmx.de> writes:

> On 28.02.25 16:41, Michal Simek wrote:
>>
>>
>> On 2/28/25 15:33, Heinrich Schuchardt wrote:
>>> On 26.02.25 23:35, Jonathan Humphreys wrote:
>>>> From: Michal Simek <michal.simek@amd.com>
>>>>
>>>> Directly fill update_info.dfu_string to prepare platforms to switch
>>>> from using dfu_alt_info variable to dfu_string which contains
>>>> description
>>>> for capsule update when switch is done.
>>>
>>> Other platforms only set the environment variable.
>>
>> Not really.
>>
>> git grep \.dfu_string board/
>>
>> beagle, imx, rpi, ti and others are also doing it.
>
> But why do we have platforms that don't?
>

I'm not aware of the history of the Xilinx platforms and why they didn't,
but Michal has fixed this.  I'm not aware of any other platforms not
setting .dfu_string.

Jon

>>
>>>
>>> Do we have a problem that needs to be solved for all problems?
>>> Or is anything special about the Xilinx platform?
>>>
>>> If we have a general problem, solving it for Xilinx only would not be
>>> the right approach.
>>
>> This is just preparation patch for switch in 3/3 because then Jon would
>> have to do this change in his patch.
>> But the biggest reason is when 2/3 is applied, capsule update will stop
>> to work on our platform and I wanted to make sure that we can avoid it.
>>
>> Thanks,
>> Michal
>>
>>