From: Patrice CHOTARD <patrice.chotard@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mmc: sti_sdhci: Fix sdhci_setup_cfg() call.
Date: Mon, 26 Aug 2019 13:48:50 +0000 [thread overview]
Message-ID: <09ab2a9f-20cd-ba4e-3c7e-0e8a8ea73096@st.com> (raw)
In-Reply-To: <20190724075102.26679-1-patrice.chotard@st.com>
On 7/24/19 9:51 AM, Patrice Chotard wrote:
> host->mmc, host->mmc->dev and host->mmc->priv must be set
> before calling sdhci_setup_cfg() to avoid hang during mmc
> initialization.
>
> Thanks to commit 3d296365e4e8
> ("mmc: sdhci: Add support for sdhci-caps-mask") which put
> this issue into evidence.
>
> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
> ---
>
> Changes in v2:
> - move host->mmc->priv initialization before sdhci_setup_cfg() call
>
> drivers/mmc/sti_sdhci.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/sti_sdhci.c b/drivers/mmc/sti_sdhci.c
> index 8ed47e113d..d6c75ea601 100644
> --- a/drivers/mmc/sti_sdhci.c
> +++ b/drivers/mmc/sti_sdhci.c
> @@ -97,14 +97,14 @@ static int sti_sdhci_probe(struct udevice *dev)
> SDHCI_QUIRK_NO_HISPD_BIT;
>
> host->host_caps = MMC_MODE_DDR_52MHz;
> + host->mmc = &plat->mmc;
> + host->mmc->dev = dev;
> + host->mmc->priv = host;
>
> ret = sdhci_setup_cfg(&plat->cfg, host, 50000000, 400000);
> if (ret)
> return ret;
>
> - host->mmc = &plat->mmc;
> - host->mmc->priv = host;
> - host->mmc->dev = dev;
> upriv->mmc = host->mmc;
>
> return sdhci_probe(dev);
Applied on STM32 tree
Thanks
prev parent reply other threads:[~2019-08-26 13:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 7:51 [U-Boot] [PATCH v2] mmc: sti_sdhci: Fix sdhci_setup_cfg() call Patrice Chotard
2019-07-24 9:12 ` [U-Boot] [PATCH v2] mmc: sti_sdhci: Fix sdhci_setup_cfg() call.【请注意,邮件由u-boot-bounces@lists.denx.de代发】 Kever Yang
2019-08-26 13:48 ` Patrice CHOTARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09ab2a9f-20cd-ba4e-3c7e-0e8a8ea73096@st.com \
--to=patrice.chotard@st.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox