public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mmc: sti_sdhci: Fix sdhci_setup_cfg() call.【请注意,邮件由u-boot-bounces@lists.denx.de代发】
Date: Wed, 24 Jul 2019 17:12:40 +0800	[thread overview]
Message-ID: <4eb5f95b-026d-c965-e896-913e3af7c426@rock-chips.com> (raw)
In-Reply-To: <20190724075102.26679-1-patrice.chotard@st.com>


On 2019/7/24 下午3:51, Patrice Chotard wrote:
> host->mmc, host->mmc->dev and host->mmc->priv must be set
> before calling sdhci_setup_cfg() to avoid hang during mmc
> initialization.
>
> Thanks to commit 3d296365e4e8
> ("mmc: sdhci: Add support for sdhci-caps-mask") which put
> this issue into evidence.
>
> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
> ---
>
> Changes in v2:
>    - move host->mmc->priv initialization before sdhci_setup_cfg() call
>
>   drivers/mmc/sti_sdhci.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/sti_sdhci.c b/drivers/mmc/sti_sdhci.c
> index 8ed47e113d..d6c75ea601 100644
> --- a/drivers/mmc/sti_sdhci.c
> +++ b/drivers/mmc/sti_sdhci.c
> @@ -97,14 +97,14 @@ static int sti_sdhci_probe(struct udevice *dev)
>   		       SDHCI_QUIRK_NO_HISPD_BIT;
>   
>   	host->host_caps = MMC_MODE_DDR_52MHz;
> +	host->mmc = &plat->mmc;
> +	host->mmc->dev = dev;
> +	host->mmc->priv = host;
>   
>   	ret = sdhci_setup_cfg(&plat->cfg, host, 50000000, 400000);
>   	if (ret)
>   		return ret;
>   
> -	host->mmc = &plat->mmc;
> -	host->mmc->priv = host;
> -	host->mmc->dev = dev;
>   	upriv->mmc = host->mmc;


Same issue like rockchip_sdhci.c.

Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
>   
>   	return sdhci_probe(dev);

  reply	other threads:[~2019-07-24  9:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-24  7:51 [U-Boot] [PATCH v2] mmc: sti_sdhci: Fix sdhci_setup_cfg() call Patrice Chotard
2019-07-24  9:12 ` Kever Yang [this message]
2019-08-26 13:48 ` Patrice CHOTARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4eb5f95b-026d-c965-e896-913e3af7c426@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox