* [PATCH] cmd: pxe_utils: add some missing tabs
@ 2023-07-27 7:12 Dan Carpenter
2023-07-27 7:15 ` AW: " Traut Manuel LCPF-CH
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dan Carpenter @ 2023-07-27 7:12 UTC (permalink / raw)
To: Simon Glass
Cc: Neil Armstrong, Patrick Delaunay, Marek Vasut, Ramon Fried,
Edoardo Tomelleri, Manuel Traut, u-boot
These lines are supposed to be indented one more tab. Otherwise it's
confusing to read.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
boot/pxe_utils.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/boot/pxe_utils.c b/boot/pxe_utils.c
index d13c47dd9429..ac1414a5f26d 100644
--- a/boot/pxe_utils.c
+++ b/boot/pxe_utils.c
@@ -702,8 +702,8 @@ static int label_boot(struct pxe_context *ctx, struct pxe_label *label)
}
}
- if (label->kaslrseed)
- label_boot_kaslrseed();
+ if (label->kaslrseed)
+ label_boot_kaslrseed();
#ifdef CONFIG_OF_LIBFDT_OVERLAY
if (label->fdtoverlays)
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* AW: [PATCH] cmd: pxe_utils: add some missing tabs
2023-07-27 7:12 [PATCH] cmd: pxe_utils: add some missing tabs Dan Carpenter
@ 2023-07-27 7:15 ` Traut Manuel LCPF-CH
2023-07-28 9:22 ` Patrick DELAUNAY
2023-08-09 1:40 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Traut Manuel LCPF-CH @ 2023-07-27 7:15 UTC (permalink / raw)
To: Dan Carpenter, Simon Glass
Cc: Neil Armstrong, Patrick Delaunay, Marek Vasut, Ramon Fried,
Edoardo Tomelleri, u-boot@lists.denx.de
> These lines are supposed to be indented one more tab. Otherwise it's confusing to read.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Manuel Traut <manuel.traut@mt.com>
> ---
> boot/pxe_utils.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/boot/pxe_utils.c b/boot/pxe_utils.c index d13c47dd9429..ac1414a5f26d 100644
> --- a/boot/pxe_utils.c
> +++ b/boot/pxe_utils.c
> @@ -702,8 +702,8 @@ static int label_boot(struct pxe_context *ctx, struct pxe_label *label)
> }
> }
>
> - if (label->kaslrseed)
> - label_boot_kaslrseed();
> + if (label->kaslrseed)
> + label_boot_kaslrseed();
>
> #ifdef CONFIG_OF_LIBFDT_OVERLAY
> if (label->fdtoverlays)
> --
> 2.39.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cmd: pxe_utils: add some missing tabs
2023-07-27 7:12 [PATCH] cmd: pxe_utils: add some missing tabs Dan Carpenter
2023-07-27 7:15 ` AW: " Traut Manuel LCPF-CH
@ 2023-07-28 9:22 ` Patrick DELAUNAY
2023-08-09 1:40 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Patrick DELAUNAY @ 2023-07-28 9:22 UTC (permalink / raw)
To: Dan Carpenter, Simon Glass
Cc: Neil Armstrong, Marek Vasut, Ramon Fried, Edoardo Tomelleri,
Manuel Traut, u-boot
Hi,
On 7/27/23 09:12, Dan Carpenter wrote:
> These lines are supposed to be indented one more tab. Otherwise it's
> confusing to read.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> boot/pxe_utils.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/boot/pxe_utils.c b/boot/pxe_utils.c
> index d13c47dd9429..ac1414a5f26d 100644
> --- a/boot/pxe_utils.c
> +++ b/boot/pxe_utils.c
> @@ -702,8 +702,8 @@ static int label_boot(struct pxe_context *ctx, struct pxe_label *label)
> }
> }
>
> - if (label->kaslrseed)
> - label_boot_kaslrseed();
> + if (label->kaslrseed)
> + label_boot_kaslrseed();
>
> #ifdef CONFIG_OF_LIBFDT_OVERLAY
> if (label->fdtoverlays)
Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
Thanks
Patrick
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cmd: pxe_utils: add some missing tabs
2023-07-27 7:12 [PATCH] cmd: pxe_utils: add some missing tabs Dan Carpenter
2023-07-27 7:15 ` AW: " Traut Manuel LCPF-CH
2023-07-28 9:22 ` Patrick DELAUNAY
@ 2023-08-09 1:40 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2023-08-09 1:40 UTC (permalink / raw)
To: Dan Carpenter
Cc: Simon Glass, Neil Armstrong, Patrick Delaunay, Marek Vasut,
Ramon Fried, Edoardo Tomelleri, Manuel Traut, u-boot
[-- Attachment #1: Type: text/plain, Size: 335 bytes --]
On Thu, Jul 27, 2023 at 10:12:39AM +0300, Dan Carpenter wrote:
> These lines are supposed to be indented one more tab. Otherwise it's
> confusing to read.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
Applied to u-boot/next, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-09 1:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-27 7:12 [PATCH] cmd: pxe_utils: add some missing tabs Dan Carpenter
2023-07-27 7:15 ` AW: " Traut Manuel LCPF-CH
2023-07-28 9:22 ` Patrick DELAUNAY
2023-08-09 1:40 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox