From: Michal Simek <michal.simek@amd.com>
To: Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH] microblaze: Rework TARGET_MICROBLAZE_GENERIC implementation
Date: Tue, 17 Mar 2026 16:35:30 +0100 [thread overview]
Message-ID: <0f352388-4e79-483a-a4ca-2f14f4bea6c8@amd.com> (raw)
In-Reply-To: <20260317144955.GC502704@bill-the-cat>
On 3/17/26 15:49, Tom Rini wrote:
> On Tue, Mar 17, 2026 at 01:06:15PM +0100, Michal Simek wrote:
>>
>>
>> On 3/17/26 02:24, Tom Rini wrote:
>>> As exposed by "make randconfig", some symbols such as
>>> XILINX_MICROBLAZE0_PVR can be set without TARGET_MICROBLAZE_GENERIC but
>>> have a transitive dependency on it. The easiest path of resolution here
>>> is that since there is only one valid microblaze "board", rework that
>>> symbol to be non-optional.
>>>
>>> Signed-off-by: Tom Rini <trini@konsulko.com>
>>> ---
>>> Cc: Michal Simek <michal.simek@amd.com>
>>> ---
>>> arch/microblaze/Kconfig | 10 +++-------
>>> 1 file changed, 3 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/arch/microblaze/Kconfig b/arch/microblaze/Kconfig
>>> index 4261e5009fdc..16c55ddfd95c 100644
>>> --- a/arch/microblaze/Kconfig
>>> +++ b/arch/microblaze/Kconfig
>>> @@ -7,12 +7,8 @@ config SYS_ARCH
>>> config STATIC_RELA
>>> def_bool y
>>> -choice
>>> - prompt "Target select"
>>> - optional
>>> -
>>> config TARGET_MICROBLAZE_GENERIC
>>> - bool "Support microblaze-generic"
>>> + def_bool y
>>> select BOARD_LATE_INIT
>>> select DM
>>> select DM_SERIAL
>>> @@ -26,8 +22,8 @@ config TARGET_MICROBLAZE_GENERIC
>>> select MTD
>>> select SPI
>>> imply CMD_DM
>>> -
>>> -endchoice
>>> + help
>>> + Support microblaze-generic
>>> source "board/xilinx/Kconfig"
>>> source "board/xilinx/microblaze-generic/Kconfig"
>>
>> Applied.
>
> Please drop this for now, I need to do a v2 and I've found another
> randconfig that gives me:
> WARNING: unmet direct dependencies detected for XILINX_MICROBLAZE0_PVR
> Depends on [n]: MICROBLAZE [=y] && TARGET_MICROBLAZE_GENERIC [=n]
> Selected by [y]:
> - CPU_MICROBLAZE [=y] && CPU [=y] && MICROBLAZE [=y]
>
I expect this is from cpuinfo driver.
M
next prev parent reply other threads:[~2026-03-17 15:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 1:24 [PATCH] microblaze: Rework TARGET_MICROBLAZE_GENERIC implementation Tom Rini
2026-03-17 12:06 ` Michal Simek
2026-03-17 14:49 ` Tom Rini
2026-03-17 15:35 ` Michal Simek [this message]
2026-03-17 15:41 ` Tom Rini
2026-03-17 15:51 ` Michal Simek
2026-03-17 16:02 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f352388-4e79-483a-a4ca-2f14f4bea6c8@amd.com \
--to=michal.simek@amd.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox