Re: [PATCH] microblaze: Rework TARGET_MICROBLAZE_GENERIC implementation

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1803 bytes --]

On Tue, Mar 17, 2026 at 01:06:15PM +0100, Michal Simek wrote:
> 
> 
> On 3/17/26 02:24, Tom Rini wrote:
> > As exposed by "make randconfig", some symbols such as
> > XILINX_MICROBLAZE0_PVR can be set without TARGET_MICROBLAZE_GENERIC but
> > have a transitive dependency on it. The easiest path of resolution here
> > is that since there is only one valid microblaze "board", rework that
> > symbol to be non-optional.
> > 
> > Signed-off-by: Tom Rini <trini@konsulko.com>
> > ---
> > Cc: Michal Simek <michal.simek@amd.com>
> > ---
> >   arch/microblaze/Kconfig | 10 +++-------
> >   1 file changed, 3 insertions(+), 7 deletions(-)
> > 
> > diff --git a/arch/microblaze/Kconfig b/arch/microblaze/Kconfig
> > index 4261e5009fdc..16c55ddfd95c 100644
> > --- a/arch/microblaze/Kconfig
> > +++ b/arch/microblaze/Kconfig
> > @@ -7,12 +7,8 @@ config SYS_ARCH
> >   config STATIC_RELA
> >   	def_bool y
> > -choice
> > -	prompt "Target select"
> > -	optional
> > -
> >   config TARGET_MICROBLAZE_GENERIC
> > -	bool "Support microblaze-generic"
> > +	def_bool y
> >   	select BOARD_LATE_INIT
> >   	select DM
> >   	select DM_SERIAL
> > @@ -26,8 +22,8 @@ config TARGET_MICROBLAZE_GENERIC
> >   	select MTD
> >   	select SPI
> >   	imply CMD_DM
> > -
> > -endchoice
> > +	help
> > +	  Support microblaze-generic
> >   source "board/xilinx/Kconfig"
> >   source "board/xilinx/microblaze-generic/Kconfig"
> 
> Applied.

Please drop this for now, I need to do a v2 and I've found another
randconfig that gives me:
WARNING: unmet direct dependencies detected for XILINX_MICROBLAZE0_PVR
  Depends on [n]: MICROBLAZE [=y] && TARGET_MICROBLAZE_GENERIC [=n]
  Selected by [y]:
  - CPU_MICROBLAZE [=y] && CPU [=y] && MICROBLAZE [=y]

with this applied.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]